Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Side by Side Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2206963002: Plumb the frame name through the popup blocker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/aw_content_browser_client.h" 5 #include "android_webview/browser/aw_content_browser_client.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "android_webview/browser/aw_browser_context.h" 9 #include "android_webview/browser/aw_browser_context.h"
10 #include "android_webview/browser/aw_browser_main_parts.h" 10 #include "android_webview/browser/aw_browser_main_parts.h"
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 client->SelectClientCertificate(cert_request_info, std::move(delegate)); 377 client->SelectClientCertificate(cert_request_info, std::move(delegate));
378 } 378 }
379 379
380 bool AwContentBrowserClient::CanCreateWindow( 380 bool AwContentBrowserClient::CanCreateWindow(
381 const GURL& opener_url, 381 const GURL& opener_url,
382 const GURL& opener_top_level_frame_url, 382 const GURL& opener_top_level_frame_url,
383 const GURL& source_origin, 383 const GURL& source_origin,
384 WindowContainerType container_type, 384 WindowContainerType container_type,
385 const GURL& target_url, 385 const GURL& target_url,
386 const content::Referrer& referrer, 386 const content::Referrer& referrer,
387 const std::string& frame_name,
387 WindowOpenDisposition disposition, 388 WindowOpenDisposition disposition,
388 const blink::WebWindowFeatures& features, 389 const blink::WebWindowFeatures& features,
389 bool user_gesture, 390 bool user_gesture,
390 bool opener_suppressed, 391 bool opener_suppressed,
391 content::ResourceContext* context, 392 content::ResourceContext* context,
392 int render_process_id, 393 int render_process_id,
393 int opener_render_view_id, 394 int opener_render_view_id,
394 int opener_render_frame_id, 395 int opener_render_frame_id,
395 bool* no_javascript_access) { 396 bool* no_javascript_access) {
396 // We unconditionally allow popup windows at this stage and will give 397 // We unconditionally allow popup windows at this stage and will give
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 512
512 #if defined(VIDEO_HOLE) 513 #if defined(VIDEO_HOLE)
513 content::ExternalVideoSurfaceContainer* 514 content::ExternalVideoSurfaceContainer*
514 AwContentBrowserClient::OverrideCreateExternalVideoSurfaceContainer( 515 AwContentBrowserClient::OverrideCreateExternalVideoSurfaceContainer(
515 content::WebContents* web_contents) { 516 content::WebContents* web_contents) {
516 return native_factory_->CreateExternalVideoSurfaceContainer(web_contents); 517 return native_factory_->CreateExternalVideoSurfaceContainer(web_contents);
517 } 518 }
518 #endif 519 #endif
519 520
520 } // namespace android_webview 521 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698