chrome/test/data/popup_blocker/check-framename.html - Issue 2206963002: Plumb the frame name through the popup blocker - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(4137)

My Issues | Starred Open | Closed | All

Unified Diff: chrome/test/data/popup_blocker/check-framename.html

Issue 2206963002: Plumb the frame name through the popup blocker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/ui/browser_navigator_params.h ('k') | chrome/test/data/popup_blocker/popup-framename.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/popup_blocker/check-framename.html

diff --git a/chrome/test/data/popup_blocker/check-openersuppressed.html b/chrome/test/data/popup_blocker/check-framename.html

similarity index 54%

copy from chrome/test/data/popup_blocker/check-openersuppressed.html

copy to chrome/test/data/popup_blocker/check-framename.html

index 954a129682c43b70e568bd663043e9fb008baa74..b6f0e20143cc3048cdb1b8dc849dd32bf2069d82 100644

--- a/chrome/test/data/popup_blocker/check-openersuppressed.html

+++ b/chrome/test/data/popup_blocker/check-framename.html

@@ -1,15 +1,17 @@

<!DOCTYPE html>

<html>

<head>

-<title>Check that window.opener is not set</title>

+<title>Check that the frame name is correct</title>

</head>

<body>

<div id="console"></div>

<script>

var log = document.querySelector("#console");

var result;

- if (window.opener != null)

- result = "FAIL: opener set";

+ if (window.name == "")

+ result = "FAIL: no name";

+ else if (window.name != "fancyname")

+ result = "FAIL: incorrect frame name: " + window.name;

else

result = "PASS";

log.innerText = result;

« no previous file with comments | « chrome/browser/ui/browser_navigator_params.h ('k') | chrome/test/data/popup_blocker/popup-framename.html » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698