chrome/test/data/popup_blocker/popup-framename.html - Issue 2206963002: Plumb the frame name through the popup blocker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/popup_blocker/popup-framename.html

Issue 2206963002: Plumb the frame name through the popup blocker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>	3 <title>

4 Check that the window.opener is not set when opening a blocked popup	4 Check that the frame name is correctly set when opening a blocked popup

5 </title>	5 </title>

6 <script>	6 <script>

7 function test() {	7 function test() {

8 window.open("check-opener.html");	8 window.open("check-framename.html", "fancyname");

9 }	9 }

10 </script>	10 </script>

11 </head>	11 </head>

12 <body onload="test()">	12 <body onload="test()">

13 pop-up test page	13 pop-up test page

14 </body>	14 </body>

15 </html>	15 </html>

OLD	NEW