[Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

[Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

JSONFeatureProvider and parsing is dead. Long live compiled feature
files.

BUG=280286
Committed: https://crrev.com/c46a48577b1b750f2561d7f3aeb45e354b45d3c4
Cr-Commit-Position: refs/heads/master@{#412408}

[Devlin, 2016-08-01 22:19:21]

Description was changed from

==========
[Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

JSONFeatureProvider and parsing is dead. Long live compiled feature
files.

BUG=280286
BUG=631416
==========

to

==========
[Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

JSONFeatureProvider and parsing is dead. Long live compiled feature
files.

BUG=280286
==========

[Devlin, 2016-08-01 22:20:21]

Patchset #2 (id:20001) has been deleted

[Devlin, 2016-08-01 22:20:27]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-08-01 22:20:45]

Patchset #1 (id:40001) has been deleted

[Devlin, 2016-08-02 22:54:43]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 22:55:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 00:18:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 00:18:56]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-08-03 15:13:35]

rdevlin.cronin@chromium.org changed reviewers:
+ dpranke@chromium.org, lazyboy@chromium.org

[Devlin, 2016-08-03 15:13:36]

Cleanup time!  Istiaque, mind taking a look?

Dirk, can you take a quick glance at the gn files?  I think I'm getting the hang
of it, but having an extra pair of eyes is always good. :)

https://codereview.chromium.org/2202733003/diff/80001/extensions/common/featu...
File extensions/common/features/simple_feature_unittest.cc (left):

https://codereview.chromium.org/2202733003/diff/80001/extensions/common/featu...
extensions/common/features/simple_feature_unittest.cc:529:
TEST_F(SimpleFeatureTest, ParseNull) {
Failure to parse now results in a compile error.  I've added a few extra tests
to the generator's unittest to account for a few new different variations.

https://codereview.chromium.org/2202733003/diff/80001/tools/json_schema_compi...
File tools/json_schema_compiler/feature_compiler.py (right):

https://codereview.chromium.org/2202733003/diff/80001/tools/json_schema_compi...
tools/json_schema_compiler/feature_compiler.py:471: parent_name =
feature_name[:sep]
This is to account for parent2.child3.child.child in api_features.json in
chrome/test/data [1].  It's unclear whether or not we really need this, but I
figured I'd try to keep this as close to original behavior as possible for now.

[1]
https://cs.chromium.org/chromium/src/chrome/test/data/extensions/extension_ap...

[Dirk Pranke, 2016-08-03 18:23:16]

lgtm

[lazyboy, 2016-08-03 18:52:20]

lgtm with one comment.

https://codereview.chromium.org/2202733003/diff/80001/extensions/common/featu...
File extensions/common/features/api_feature.h (right):

https://codereview.chromium.org/2202733003/diff/80001/extensions/common/featu...
extensions/common/features/api_feature.h:14: class APIFeature : public
SimpleFeature {
APIFeature has become SimpleFeature now, should we just nuke it?

A bunch of code expects APIFeature to be defined, so an incremental approach
could be to just "using APIFeature = SimpleFeature" and delete the contents of
this class, and add a TODO.

https://codereview.chromium.org/2202733003/diff/80001/extensions/common/featu...
File extensions/common/features/simple_feature_unittest.cc (left):

https://codereview.chromium.org/2202733003/diff/80001/extensions/common/featu...
extensions/common/features/simple_feature_unittest.cc:529:
TEST_F(SimpleFeatureTest, ParseNull) {
On 2016/08/03 15:13:36, Devlin wrote:
> Failure to parse now results in a compile error.  I've added a few extra tests
> to the generator's unittest to account for a few new different variations.

Acknowledged.

[Devlin, 2016-08-03 19:26:21]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[Devlin, 2016-08-03 19:26:25]

https://codereview.chromium.org/2202733003/diff/80001/extensions/common/featu...
File extensions/common/features/api_feature.h (right):

https://codereview.chromium.org/2202733003/diff/80001/extensions/common/featu...
extensions/common/features/api_feature.h:14: class APIFeature : public
SimpleFeature {
On 2016/08/03 18:52:20, lazyboy wrote:
> APIFeature has become SimpleFeature now, should we just nuke it?
> 
> A bunch of code expects APIFeature to be defined, so an incremental approach
> could be to just "using APIFeature = SimpleFeature" and delete the contents of
> this class, and add a TODO.

Interesting idea!  The feature compiler also currently relies on the existence
of an APIFeature class, so the incremental approach sounds best.  But it could
be fun to clean this up, and maybe even behavior/manifest/permission features as
well, since they have pretty trivial logic, and when dealing with the number of
features we have, all those vtables can actually add up a bit.

Removed the class; added the using.

[commit-bot: I haz the power, 2016-08-03 19:27:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-03 19:27:05]

rdevlin.cronin@chromium.org changed reviewers:
+ thakis@chromium.org

[Devlin, 2016-08-03 19:27:06]

+thakis - chrome/OWNER needed for mods to chrome/common/BUILD.gn.  Nico, mind
taking a quick look?

[commit-bot: I haz the power, 2016-08-03 21:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:17:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-08-16 19:33:15]

rdevlin.cronin@chromium.org changed reviewers:
+ thestig@chromium.org
- thakis@chromium.org

[Devlin, 2016-08-16 19:33:17]

s/nico/lei

[Lei Zhang, 2016-08-16 19:41:57]

https://codereview.chromium.org/2202733003/diff/100001/chrome/common/extensio...
File chrome/common/extensions/api/common_extension_api_unittest.cc (right):

https://codereview.chromium.org/2202733003/diff/100001/chrome/common/extensio...
chrome/common/extensions/api/common_extension_api_unittest.cc:160: const char*
test_features[] = {
const char* const kTestFeatures[]

https://codereview.chromium.org/2202733003/diff/100001/chrome/common/extensio...
chrome/common/extensions/api/common_extension_api_unittest.cc:243: const char*
test_features[] = {
Ditto, or just declare this once in an anonymous namespace?

[Lei Zhang, 2016-08-16 19:42:07]

lgtm

[Devlin, 2016-08-16 23:49:42]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 23:50:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 23:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:53:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Devlin, 2016-08-17 00:03:10]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 00:03:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 00:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 00:51:57]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-08-17 01:10:35]

https://codereview.chromium.org/2202733003/diff/100001/chrome/common/extensio...
File chrome/common/extensions/api/common_extension_api_unittest.cc (right):

https://codereview.chromium.org/2202733003/diff/100001/chrome/common/extensio...
chrome/common/extensions/api/common_extension_api_unittest.cc:160: const char*
test_features[] = {
On 2016/08/16 19:41:57, Lei Zhang wrote:
> const char* const kTestFeatures[]

Done.

https://codereview.chromium.org/2202733003/diff/100001/chrome/common/extensio...
chrome/common/extensions/api/common_extension_api_unittest.cc:243: const char*
test_features[] = {
On 2016/08/16 19:41:57, Lei Zhang wrote:
> Ditto, or just declare this once in an anonymous namespace?

Done.

[Devlin, 2016-08-17 01:11:21]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-08-17 01:11:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, lazyboy@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2202733003/#ps120001
(title: "Lei's")

[commit-bot: I haz the power, 2016-08-17 01:11:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 01:16:41]

Description was changed from

==========
[Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

JSONFeatureProvider and parsing is dead. Long live compiled feature
files.

BUG=280286
==========

to

==========
[Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

JSONFeatureProvider and parsing is dead. Long live compiled feature
files.

BUG=280286
==========

[commit-bot: I haz the power, 2016-08-17 01:16:42]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-08-17 01:19:40]

Description was changed from

==========
[Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

JSONFeatureProvider and parsing is dead. Long live compiled feature
files.

BUG=280286
==========

to

==========
[Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

JSONFeatureProvider and parsing is dead. Long live compiled feature
files.

BUG=280286

Committed: https://crrev.com/c46a48577b1b750f2561d7f3aeb45e354b45d3c4
Cr-Commit-Position: refs/heads/master@{#412408}
==========

[commit-bot: I haz the power, 2016-08-17 01:19:41]

Patchset 4 (id:??) landed as
https://crrev.com/c46a48577b1b750f2561d7f3aeb45e354b45d3c4
Cr-Commit-Position: refs/heads/master@{#412408}