Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/json_schema_compiler/feature_compiler_test.py

Issue 2202733003: [Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lei's Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/feature_compiler_test.py
diff --git a/tools/json_schema_compiler/feature_compiler_test.py b/tools/json_schema_compiler/feature_compiler_test.py
index 4462e46d1095620e3e6d4ecb6f79f57686d85544..37d829eedebca0a0964916358834d5f4ce7dc942 100755
--- a/tools/json_schema_compiler/feature_compiler_test.py
+++ b/tools/json_schema_compiler/feature_compiler_test.py
@@ -50,6 +50,13 @@ class FeatureCompilerTest(unittest.TestCase):
})
self.assertFalse(f.errors)
+ def testInvalidAll(self):
+ f = self._parseFeature({
+ 'channel': 'stable',
+ 'dependencies': 'all',
+ })
+ self._hasError(f, 'Illegal value: "all"')
+
def testUnknownKeyError(self):
f = self._parseFeature({
'contexts': ['blessed_extension'],
« no previous file with comments | « tools/json_schema_compiler/feature_compiler.py ('k') | tools/json_schema_compiler/test/features_generation_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698