Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: extensions/common/features/api_feature.h

Issue 2202733003: [Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lei's Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_ 5 #ifndef EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_
6 #define EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_ 6 #define EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_
7 7
8 #include <string>
9
10 #include "extensions/common/features/simple_feature.h" 8 #include "extensions/common/features/simple_feature.h"
11 9
12 namespace extensions { 10 namespace extensions {
13 11
14 class APIFeature : public SimpleFeature { 12 // TODO(devlin): APIFeatures are just SimpleFeatures now. However, there's a
15 public: 13 // bunch of stuff (including the feature compiler) that relies on the presence
16 APIFeature(); 14 // of an APIFeature class. For now, just typedef this, but eventually we should
17 ~APIFeature() override; 15 // remove it.
18 16 using APIFeature = SimpleFeature;
19 // extensions::Feature:
20 bool Validate(std::string* error) override;
21 };
22 17
23 } // namespace extensions 18 } // namespace extensions
24 19
25 #endif // EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_ 20 #endif // EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_
OLDNEW
« no previous file with comments | « chrome/common/extensions/chrome_extensions_client.cc ('k') | extensions/common/features/api_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698