Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: extensions/common/features/simple_feature.h

Issue 2202733003: [Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lei's Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/permission_feature.cc ('k') | extensions/common/features/simple_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/simple_feature.h
diff --git a/extensions/common/features/simple_feature.h b/extensions/common/features/simple_feature.h
index fb931562298d7780739ed0c411a69535105ae1cb..59db2be5cf856062e0e9aafe45421e8489aad45b 100644
--- a/extensions/common/features/simple_feature.h
+++ b/extensions/common/features/simple_feature.h
@@ -47,15 +47,6 @@ class SimpleFeature : public Feature {
SimpleFeature();
~SimpleFeature() override;
- // Parses the JSON representation of a feature into the fields of this object.
- // Note: Validate() should be called after this.
- void Parse(const base::DictionaryValue* dictionary);
-
- // Checks whether the feature is valid. Invalid features should not be used.
- // Subclasses can override to implement specific checking, but should always
- // call this method as well.
- virtual bool Validate(std::string* error);
-
Availability IsAvailableToContext(const Extension* extension,
Context context) const {
return IsAvailableToContext(extension, context, GURL());
« no previous file with comments | « extensions/common/features/permission_feature.cc ('k') | extensions/common/features/simple_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698