extensions/common/features/api_feature.h - Issue 2202733003: [Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/features/api_feature.h

Issue 2202733003: [Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/chrome_extensions_client.cc ('k') | extensions/common/features/api_feature.cc » ('j') | extensions/common/features/simple_feature_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_	5 #ifndef EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_

6 #define EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_	6 #define EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "extensions/common/features/simple_feature.h"	10 #include "extensions/common/features/simple_feature.h"

11	11

12 namespace extensions {	12 namespace extensions {

13	13

14 class APIFeature : public SimpleFeature {	14 class APIFeature : public SimpleFeature {
	lazyboy 2016/08/03 18:52:20 APIFeature has become SimpleFeature now, should we APIFeature has become SimpleFeature now, should we just nuke it? A bunch of code expects APIFeature to be defined, so an incremental approach could be to just "using APIFeature = SimpleFeature" and delete the contents of this class, and add a TODO. Devlin 2016/08/03 19:26:25 Interesting idea! The feature compiler also curre Show quoted text On 2016/08/03 18:52:20, lazyboy wrote: > APIFeature has become SimpleFeature now, should we just nuke it? > > A bunch of code expects APIFeature to be defined, so an incremental approach > could be to just "using APIFeature = SimpleFeature" and delete the contents of > this class, and add a TODO. Interesting idea! The feature compiler also currently relies on the existence of an APIFeature class, so the incremental approach sounds best. But it could be fun to clean this up, and maybe even behavior/manifest/permission features as well, since they have pretty trivial logic, and when dealing with the number of features we have, all those vtables can actually add up a bit. Removed the class; added the using.
15 public:	15 public:

16 APIFeature();	16 APIFeature();

17 ~APIFeature() override;	17 ~APIFeature() override;

18

19 // extensions::Feature:

20 bool Validate(std::string* error) override;

21 };	18 };

22	19

23 } // namespace extensions	20 } // namespace extensions

24	21

25 #endif // EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_	22 #endif // EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_

OLD	NEW