Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2777)

Unified Diff: extensions/common/features/api_feature.h

Issue 2202733003: [Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lei's Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/chrome_extensions_client.cc ('k') | extensions/common/features/api_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/api_feature.h
diff --git a/extensions/common/features/api_feature.h b/extensions/common/features/api_feature.h
index 38247dc073166b26ee0bd5ee114303c01fee4e27..bf494f284a5e91a5f2892e3294494dd36f22b67a 100644
--- a/extensions/common/features/api_feature.h
+++ b/extensions/common/features/api_feature.h
@@ -5,20 +5,15 @@
#ifndef EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_
#define EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_
-#include <string>
-
#include "extensions/common/features/simple_feature.h"
namespace extensions {
-class APIFeature : public SimpleFeature {
- public:
- APIFeature();
- ~APIFeature() override;
-
- // extensions::Feature:
- bool Validate(std::string* error) override;
-};
+// TODO(devlin): APIFeatures are just SimpleFeatures now. However, there's a
+// bunch of stuff (including the feature compiler) that relies on the presence
+// of an APIFeature class. For now, just typedef this, but eventually we should
+// remove it.
+using APIFeature = SimpleFeature;
} // namespace extensions
« no previous file with comments | « chrome/common/extensions/chrome_extensions_client.cc ('k') | extensions/common/features/api_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698