Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: extensions/common/features/manifest_feature.cc

Issue 2202733003: [Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lei's Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/manifest_feature.h ('k') | extensions/common/features/permission_feature.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/manifest_feature.cc
diff --git a/extensions/common/features/manifest_feature.cc b/extensions/common/features/manifest_feature.cc
index 313142d6843e106c64fe5c35e4ff53af10b49ecb..4d36d5278d161f4eb8ff2ec9da5e99da50c73802 100644
--- a/extensions/common/features/manifest_feature.cc
+++ b/extensions/common/features/manifest_feature.cc
@@ -34,22 +34,4 @@ Feature::Availability ManifestFeature::IsAvailableToContext(
return CreateAvailability(IS_AVAILABLE);
}
-bool ManifestFeature::Validate(std::string* error) {
- if (!SimpleFeature::Validate(error))
- return false;
-
- if (extension_types().empty()) {
- *error = name() + ": Manifest features must specify at least one " +
- "value for extension_types.";
- return false;
- }
-
- if (!contexts().empty()) {
- *error = name() + ": Manifest features do not support contexts.";
- return false;
- }
-
- return true;
-}
-
} // namespace extensions
« no previous file with comments | « extensions/common/features/manifest_feature.h ('k') | extensions/common/features/permission_feature.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698