[Extensions] Remove JSONFeatureProvider, SimpleFeature::Parse

tools/json_schema_compiler/feature_compiler.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import copy
 from datetime import datetime
 from functools import partial
 import os
 
@@ skipping 442 matching lines @@
       no_parent_values = ['noparent' in v for v in feature_value]
       no_parent = all(no_parent_values)
       assert no_parent or not any(no_parent_values), (
               '"%s:" All child features must contain the same noparent value' %
                   feature_name)
     else:
       no_parent = 'noparent' in feature_value
     sep = feature_name.rfind('.')
     if sep is -1 or no_parent:
       return None
+
     parent_name = feature_name[:sep]
-    if parent_name not in self._features:
+    while sep != -1 and parent_name not in self._features:
+      # This recursion allows for a feature to have a parent that isn't a direct
+      # ancestor. For instance, we could have feature 'alpha', and feature
+      # 'alpha.child.child', where 'alpha.child.child' inherits from 'alpha'.
+      # TODO(devlin): Is this useful? Or logical?
+      sep = feature_name.rfind('.', 0, sep)
+      parent_name = feature_name[:sep]

[Devlin, 2016/08/03 15:13:36]

This is to account for parent2.child3.child.child in api_features.json in
chrome/test/data [1].  It's unclear whether or not we really need this, but I
figured I'd try to keep this as close to original behavior as possible for now.

[1]
https://cs.chromium.org/chromium/src/chrome/test/data/extensions/extension_ap...

+
+    if sep == -1:
       # TODO(devlin): It'd be kind of nice to be able to assert that the
       # deduced parent name is in our features, but some dotted features don't
       # have parents and also don't have noparent, e.g. system.cpu. We should
       # probably just noparent them so that we can assert this.
       #   raise KeyError('Could not find parent "%s" for feature "%s".' %
       #                      (parent_name, feature_name))
       return None
     parent_value = self._features[parent_name]
     parent = parent_value
     if type(parent_value) is list:
@@ skipping 119 matching lines @@
   parser.add_argument('source_files', type=str, nargs='+',
                       help='The source features.json files')
   args = parser.parse_args()
   if args.feature_class not in FEATURE_CLASSES:
     raise NameError('Unknown feature class: %s' % args.feature_class)
   c = FeatureCompiler(args.chrome_root, args.source_files, args.feature_class,
                       args.provider_class, args.out_root,
                       args.out_base_filename)
   c.Compile()
   c.Write()