cc: Delete the Renderer base class.

cc: Delete the Renderer base class.

Makes DirectRenderer and DelegatingRenderer into concrete
independent classes.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92
Cr-Commit-Position: refs/heads/master@{#412617}

[danakj, 2016-07-30 03:48:15]

Description was changed from

==========
cc: Delete the Renderer base class.

Makes DelegatingRenderer into a concrete independent class.

This points out a bunch of unused code in DirectRenderer and its
subclasses since SetVisible() is never called on DirectRenderer.

R=enne
BUG=606056
==========

to

==========
cc: Delete the Renderer base class.

Makes DelegatingRenderer into a concrete independent class.

This points out a bunch of unused code in DirectRenderer and its
subclasses since SetVisible() is never called on DirectRenderer.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-07-30 03:50:21]

There's some comments in this patch about things I didn't get to yet or need to
understand (like the NO_BINDINGS thing in GLRenderer).

Also, why don't we SetVisible(false) on windows that get minimized (or are on
background workspaces) on Desktop? :( Well, since we don't deleting it all.

[danakj, 2016-07-30 04:00:49]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 04:01:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 04:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 04:03:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[enne (OOO), 2016-08-08 21:41:18]

Looks good in general!

https://codereview.chromium.org/2194013002/diff/20001/cc/output/delegating_re...
File cc/output/delegating_renderer.h (right):

https://codereview.chromium.org/2194013002/diff/20001/cc/output/delegating_re...
cc/output/delegating_renderer.h:35: // REMOVE THIS.
Are you going to remove this here?

https://codereview.chromium.org/2194013002/diff/20001/cc/output/direct_render...
File cc/output/direct_renderer.h (right):

https://codereview.chromium.org/2194013002/diff/20001/cc/output/direct_render...
cc/output/direct_renderer.h:55: // DO THIS: protected:
?

https://codereview.chromium.org/2194013002/diff/20001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2194013002/diff/20001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:2907: // WHY???
This doesn't seem needed to me, but feel free to remove it in another patch if
you want to mitigate risk with this patch.

[danakj, 2016-08-16 23:49:04]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-08-16 23:49:27]

Description was changed from

==========
cc: Delete the Renderer base class.

Makes DelegatingRenderer into a concrete independent class.

This points out a bunch of unused code in DirectRenderer and its
subclasses since SetVisible() is never called on DirectRenderer.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Delete the Renderer base class.

Makes DirectRenderer and DelegatingRenderer into concrete
independent classes.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-16 23:49:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-08-16 23:49:53]

Erm, that is to say. I redid this now.

[danakj, 2016-08-16 23:51:57]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-08-16 23:52:11]

Patchset #3 (id:40001) has been deleted

[danakj, 2016-08-16 23:52:25]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-08-17 02:13:20]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 02:13:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 02:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 02:15:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[enne (OOO), 2016-08-17 17:36:39]

lgtm

[danakj, 2016-08-17 17:44:00]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 17:44:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 18:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 18:41:03]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-08-17 19:52:09]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-08-17 19:52:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 19:58:02]

Description was changed from

==========
cc: Delete the Renderer base class.

Makes DirectRenderer and DelegatingRenderer into concrete
independent classes.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Delete the Renderer base class.

Makes DirectRenderer and DelegatingRenderer into concrete
independent classes.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-17 19:58:03]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-08-17 20:03:50]

Description was changed from

==========
cc: Delete the Renderer base class.

Makes DirectRenderer and DelegatingRenderer into concrete
independent classes.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Delete the Renderer base class.

Makes DirectRenderer and DelegatingRenderer into concrete
independent classes.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92
Cr-Commit-Position: refs/heads/master@{#412617}
==========

[commit-bot: I haz the power, 2016-08-17 20:03:51]

Patchset 4 (id:??) landed as
https://crrev.com/db49547c7bbadfaa155607339856944a7eb5fa92
Cr-Commit-Position: refs/heads/master@{#412617}