Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Issue 2254543003: cc: Delete the RendererClient class. (Closed)

Created:
4 years, 4 months ago by danakj
Modified:
4 years, 4 months ago
Reviewers:
enne (OOO)
CC:
boliu, cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@setvisible-browser
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Delete the RendererClient class. Just call SetFullViewportDamage from Display::SetVisible(false). The drops the Ensure/DiscardBackbuffer methods from the DirectRenderer API also, and just does EnsureBackbuffer when SetVisible(true) in GLRenderer which matches the SoftwareRenderer. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/b902c676708c16da0e94f454a29cc6e84a21e659 Cr-Commit-Position: refs/heads/master@{#412430}

Patch Set 1 : deleterendererclient: . #

Patch Set 2 : deleterendererclient: ccpt #

Patch Set 3 : deleterendererclient: rebase #

Patch Set 4 : deleterendererclient: rebase #

Patch Set 5 : deleterendererclient: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -346 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/input/scroll_elasticity_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/delegating_renderer.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/output/delegating_renderer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/output/direct_renderer.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/output/direct_renderer.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M cc/output/gl_renderer.h View 4 chunks +1 line, -8 lines 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +7 lines, -27 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 25 chunks +36 lines, -136 lines 0 comments Download
M cc/output/overlay_unittest.cc View 4 chunks +3 lines, -17 lines 0 comments Download
M cc/output/renderer.h View 2 chunks +3 lines, -9 lines 0 comments Download
M cc/output/software_renderer.h View 3 chunks +4 lines, -8 lines 0 comments Download
M cc/output/software_renderer.cc View 3 chunks +8 lines, -31 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M cc/surfaces/display.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/surfaces/display.cc View 3 chunks +10 lines, -8 lines 0 comments Download
D cc/test/fake_renderer_client.h View 1 chunk +0 lines, -30 lines 0 comments Download
M cc/test/pixel_test.h View 5 chunks +7 lines, -16 lines 0 comments Download
M cc/test/pixel_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 3 chunks +1 line, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 10 chunks +12 lines, -15 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_perftest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_damage.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (18 generated)
danakj
4 years, 4 months ago (2016-08-16 21:26:15 UTC) #3
enne (OOO)
lgtm
4 years, 4 months ago (2016-08-16 21:37:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254543003/30025
4 years, 4 months ago (2016-08-17 02:13:18 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:30025)
4 years, 4 months ago (2016-08-17 02:34:09 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 02:36:12 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b902c676708c16da0e94f454a29cc6e84a21e659
Cr-Commit-Position: refs/heads/master@{#412430}

Powered by Google App Engine
This is Rietveld 408576698