Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: cc/output/gl_renderer_unittest.cc

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/renderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer_unittest.cc
diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc
index f7178038719cd8504c58192a97038aa73622fd2f..d5df55aa5e2af5a3a06319dbce0565b9a3f475de 100644
--- a/cc/output/gl_renderer_unittest.cc
+++ b/cc/output/gl_renderer_unittest.cc
@@ -64,11 +64,11 @@ class GLRendererTest : public testing::Test {
RenderPass* root_render_pass() {
return render_passes_in_draw_order_.back().get();
}
- void DrawFrame(Renderer* renderer, const gfx::Rect& viewport_rect) {
+ void DrawFrame(GLRenderer* renderer, const gfx::Rect& viewport_rect) {
renderer->DrawFrame(&render_passes_in_draw_order_, 1.f, gfx::ColorSpace(),
viewport_rect, viewport_rect);
}
- void DrawFrame(Renderer* renderer,
+ void DrawFrame(GLRenderer* renderer,
const gfx::Rect& viewport_rect,
const gfx::Rect& clip_rect) {
renderer->DrawFrame(&render_passes_in_draw_order_, 1.f, gfx::ColorSpace(),
@@ -2109,7 +2109,7 @@ class GLRendererWithMockContextTest : public ::testing::Test {
scoped_refptr<MockContextProvider> context_provider_;
std::unique_ptr<OutputSurface> output_surface_;
std::unique_ptr<ResourceProvider> resource_provider_;
- std::unique_ptr<Renderer> renderer_;
+ std::unique_ptr<GLRenderer> renderer_;
};
TEST_F(GLRendererWithMockContextTest,
@@ -2124,8 +2124,6 @@ TEST_F(GLRendererWithMockContextTest,
renderer_->SetVisible(true);
Mock::VerifyAndClearExpectations(context_support_ptr_);
- EXPECT_TRUE(renderer_->visible());
-
EXPECT_CALL(*context_support_ptr_, SetClientVisible(0, false));
EXPECT_CALL(*context_support_ptr_, AnyClientsVisible())
.WillOnce(Return(false));
@@ -2133,8 +2131,6 @@ TEST_F(GLRendererWithMockContextTest,
EXPECT_CALL(*context_support_ptr_, SetAggressivelyFreeResources(true));
renderer_->SetVisible(false);
Mock::VerifyAndClearExpectations(context_support_ptr_);
-
- EXPECT_FALSE(renderer_->visible());
}
} // namespace
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698