Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3879)

Unified Diff: cc/output/delegating_renderer.cc

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/delegating_renderer.h ('k') | cc/output/direct_renderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/delegating_renderer.cc
diff --git a/cc/output/delegating_renderer.cc b/cc/output/delegating_renderer.cc
index 65b6e0d1e1e7f3be3472ce557f69e1d3e938f735..72aa7d747e661b57b1619129ba4f5b7c6bcbaacc 100644
--- a/cc/output/delegating_renderer.cc
+++ b/cc/output/delegating_renderer.cc
@@ -20,12 +20,9 @@
namespace cc {
-DelegatingRenderer::DelegatingRenderer(const RendererSettings* settings,
- OutputSurface* output_surface,
+DelegatingRenderer::DelegatingRenderer(OutputSurface* output_surface,
ResourceProvider* resource_provider)
- : Renderer(settings),
- output_surface_(output_surface),
- resource_provider_(resource_provider) {
+ : output_surface_(output_surface), resource_provider_(resource_provider) {
DCHECK(resource_provider_);
capabilities_.using_partial_swap = false;
@@ -56,21 +53,12 @@ DelegatingRenderer::DelegatingRenderer(const RendererSettings* settings,
}
}
-DelegatingRenderer::~DelegatingRenderer() {}
+DelegatingRenderer::~DelegatingRenderer() = default;
-const RendererCapabilitiesImpl& DelegatingRenderer::Capabilities() const {
- return capabilities_;
-}
-
-void DelegatingRenderer::DrawFrame(RenderPassList* render_passes_in_draw_order,
- float device_scale_factor,
- const gfx::ColorSpace& device_color_space,
- const gfx::Rect& device_viewport_rect,
- const gfx::Rect& device_clip_rect) {
+void DelegatingRenderer::DrawFrame(
+ RenderPassList* render_passes_in_draw_order) {
TRACE_EVENT0("cc", "DelegatingRenderer::DrawFrame");
- DCHECK(!delegated_frame_data_);
-
delegated_frame_data_ = base::WrapUnique(new DelegatedFrameData);
DelegatedFrameData& out_data = *delegated_frame_data_;
// Move the render passes and resources into the |out_frame|.
@@ -95,9 +83,4 @@ void DelegatingRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
output_surface_->SwapBuffers(std::move(compositor_frame));
}
-void DelegatingRenderer::ReclaimResources(
- const ReturnedResourceArray& resources) {
- resource_provider_->ReceiveReturnsFromParent(resources);
-}
-
} // namespace cc
« no previous file with comments | « cc/output/delegating_renderer.h ('k') | cc/output/direct_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698