Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2822)

Unified Diff: cc/output/gl_renderer.cc

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.h ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index b0a6983d38a464261c91c318d126b79426366104..1f8b84df8e2f55a591675846096df4b66887b438 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -35,6 +35,7 @@
#include "cc/output/layer_quad.h"
#include "cc/output/output_surface.h"
#include "cc/output/render_surface_filters.h"
+#include "cc/output/renderer_settings.h"
#include "cc/output/static_geometry_binding.h"
#include "cc/output/texture_mailbox_deleter.h"
#include "cc/quads/draw_polygon.h"
@@ -447,7 +448,7 @@ const RendererCapabilitiesImpl& GLRenderer::Capabilities() const {
}
void GLRenderer::DidChangeVisibility() {
- if (visible()) {
+ if (visible_) {
output_surface_->EnsureBackbuffer();
} else {
TRACE_EVENT0("cc", "GLRenderer::DidChangeVisibility dropping resources");
@@ -461,7 +462,7 @@ void GLRenderer::DidChangeVisibility() {
// ContextProvider is not shared, so always pass 0 for the client_id.
// TODO(crbug.com/487471): Update this when we share compositor
// ContextProviders.
- context_support_->SetClientVisible(0 /* client_id */, visible());
+ context_support_->SetClientVisible(0 /* client_id */, visible_);
bool aggressively_free_resources = !context_support_->AnyClientsVisible();
if (aggressively_free_resources)
output_surface_->context_provider()->DeleteCachedResources();
@@ -2898,7 +2899,7 @@ void GLRenderer::DrawQuadGeometry(const gfx::Transform& projection_matrix,
}
void GLRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
- DCHECK(visible());
+ DCHECK(visible_);
TRACE_EVENT0("cc,benchmark", "GLRenderer::SwapBuffers");
// We're done! Time to swapbuffers!
« no previous file with comments | « cc/output/gl_renderer.h ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698