[DevTools] Cleanup v8_inspector API part 2.

[DevTools] Cleanup v8_inspector API part 2.

BUG=631162
Committed: https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4
Cr-Commit-Position: refs/heads/master@{#407602}

[dgozman, 2016-07-23 23:07:27]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 23:07:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-24 00:18:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-24 00:18:10]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-07-24 04:57:37]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[dgozman, 2016-07-24 04:57:37]

Could you please take a look?

[pfeldman, 2016-07-25 17:33:29]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-07-25 17:33:30]

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
(right):

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:23:
virtual void muteWarningsAndDeprecations(int contextGroupId) = 0;
Now that runtime errors are handled in v8_inspector, this should no longer be
needed.

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:24:
virtual void unmuteWarningsAndDeprecations(int contextGroupId) = 0;
ditto

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:29:
virtual bool isExecutionAllowed() = 0;
You have a TODO to remove this.

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:30:
virtual double currentTimeMS() = 0;
Should we extract Platform from Client?

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:31:
virtual v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) =
0;
This is still not pretty.

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:32:
virtual bool isInspectableHeapObject(v8::Local<v8::Object>) = 0;
I'd rather optionally install implementation of this callback.

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:33:
virtual void enableAsyncInstrumentation() = 0;
I don't think we save anything with these, lets report async at all times.

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:34:
virtual void disableAsyncInstrumentation() = 0;
ditto

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:35:
virtual void beginEnsureAllContextsInGroup(int contextGroupId) = 0;
I don't get what it does from its name.

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:40:
virtual void consoleTime(const String16& title) = 0;
TODO: remove these since tracing is available in v8.

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h:48:
virtual void startRepeatingTimer(double, TimerCallback, void* data) = 0;
Looks like platform.

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
(right):

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h:33:
virtual void schedulePauseOnNextStatement(const String16& breakReason, const
String16& dataJSON) = 0;
dataJSON -> breakDetails?

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h:41:
static const char backtraceObjectGroup[];
The only usage of this wraps node in DOMDebugger, while we could send either
nodeId of backendNodeId there, so this could go.

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h:43:
virtual v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId,
v8::Local<v8::Context>* = nullptr, String16* objectGroup = nullptr) = 0;
unwrapObject

[kozy, 2016-07-25 17:36:51]

lgtm

[dgozman, 2016-07-25 17:44:08]

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
(right):

https://codereview.chromium.org/2179683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h:33:
virtual void schedulePauseOnNextStatement(const String16& breakReason, const
String16& dataJSON) = 0;
On 2016/07/25 17:33:30, pfeldman wrote:
> dataJSON -> breakDetails?

Done.

[dgozman, 2016-07-25 19:12:14]

Description was changed from

==========
[DevTools] Cleanup v8_inspector API part 2.

BUG=580337
==========

to

==========
[DevTools] Cleanup v8_inspector API part 2.

BUG=631162
==========

[dgozman, 2016-07-25 19:12:43]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-25 19:12:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2179683002/#ps20001
(title: "breakDetails")

[commit-bot: I haz the power, 2016-07-25 19:13:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 21:55:15]

Description was changed from

==========
[DevTools] Cleanup v8_inspector API part 2.

BUG=631162
==========

to

==========
[DevTools] Cleanup v8_inspector API part 2.

BUG=631162
==========

[commit-bot: I haz the power, 2016-07-25 21:55:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-25 21:57:35]

Description was changed from

==========
[DevTools] Cleanup v8_inspector API part 2.

BUG=631162
==========

to

==========
[DevTools] Cleanup v8_inspector API part 2.

BUG=631162

Committed: https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4
Cr-Commit-Position: refs/heads/master@{#407602}
==========

[commit-bot: I haz the power, 2016-07-25 21:57:36]

Patchset 2 (id:??) landed as
https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4
Cr-Commit-Position: refs/heads/master@{#407602}