third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h - Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: breakDetails Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

index 6d3caaebf50dc4dbbc70ed1b591a2d42a285a75f..6b9a1da766fcda4e8e56cf2e99273dfa2d91e43c 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

@@ -25,15 +25,14 @@ public:

virtual void addInspectedObject(std::unique_ptr<Inspectable>) = 0;

// Dispatching protocol messages.

- // TODO(dgozman): generate this one.

- static bool isV8ProtocolMethod(const String16& method);

+ static bool canDispatchMethod(const String16& method);

virtual void dispatchProtocolMessage(const String16& message) = 0;

virtual String16 stateJSON() = 0;

// Debugger actions.

- virtual void schedulePauseOnNextStatement(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data) = 0;

+ virtual void schedulePauseOnNextStatement(const String16& breakReason, const String16& breakDetails) = 0;

virtual void cancelPauseOnNextStatement() = 0;

- virtual void breakProgram(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data) = 0;

+ virtual void breakProgram(const String16& breakReason, const String16& breakDetails) = 0;

virtual void setSkipAllPauses(bool) = 0;

virtual void resume() = 0;

virtual void stepOver() = 0;