[DevTools] Cleanup v8_inspector API part 2.

third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8DebuggerClient_h
 #define V8DebuggerClient_h
 
 #include "platform/inspector_protocol/Platform.h"
 #include "platform/v8_inspector/public/V8ConsoleTypes.h"
 #include "platform/v8_inspector/public/V8ContextInfo.h"
 
 #include <v8.h>
 
 namespace blink {
 
 class V8StackTrace;
 
 class PLATFORM_EXPORT V8DebuggerClient {
 public:
     virtual ~V8DebuggerClient() { }
     virtual void runMessageLoopOnPause(int contextGroupId) = 0;
     virtual void quitMessageLoopOnPause() = 0;
     virtual void muteWarningsAndDeprecations(int contextGroupId) = 0;

[pfeldman, 2016/07/25 17:33:30]

Now that runtime errors are handled in v8_inspector, this should no longer be
needed.

     virtual void unmuteWarningsAndDeprecations(int contextGroupId) = 0;

[pfeldman, 2016/07/25 17:33:30]

ditto

     virtual void beginUserGesture() = 0;
     virtual void endUserGesture() = 0;
-    virtual bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) = 0;
     virtual String16 valueSubtype(v8::Local<v8::Value>) = 0;
     virtual bool formatAccessorsAsProperties(v8::Local<v8::Value>) = 0;
     virtual bool isExecutionAllowed() = 0;

[pfeldman, 2016/07/25 17:33:29]

You have a TODO to remove this.

     virtual double currentTimeMS() = 0;

[pfeldman, 2016/07/25 17:33:30]

Should we extract Platform from Client?

     virtual v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) = 0;

[pfeldman, 2016/07/25 17:33:30]

This is still not pretty.

     virtual bool isInspectableHeapObject(v8::Local<v8::Object>) = 0;

[pfeldman, 2016/07/25 17:33:29]

I'd rather optionally install implementation of this callback.

     virtual void enableAsyncInstrumentation() = 0;

[pfeldman, 2016/07/25 17:33:30]

I don't think we save anything with these, lets report async at all times.

     virtual void disableAsyncInstrumentation() = 0;

[pfeldman, 2016/07/25 17:33:30]

ditto

+    virtual void beginEnsureAllContextsInGroup(int contextGroupId) = 0;

[pfeldman, 2016/07/25 17:33:30]

I don't get what it does from its name.

+    virtual void endEnsureAllContextsInGroup(int contextGroupId) = 0;
 
     virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) = 0;
 
     virtual void consoleTime(const String16& title) = 0;

[pfeldman, 2016/07/25 17:33:30]

TODO: remove these since tracing is available in v8.

     virtual void consoleTimeEnd(const String16& title) = 0;
     virtual void consoleTimeStamp(const String16& title) = 0;
     virtual void consoleAPIMessage(int contextGroupId, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) = 0;
 
     virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) = 0;
 
     typedef void (*TimerCallback)(void*);
     virtual void startRepeatingTimer(double, TimerCallback, void* data) = 0;

[pfeldman, 2016/07/25 17:33:30]

Looks like platform.

     virtual void cancelTimer(void* data) = 0;
 };
 
 } // namespace blink
 
 
 #endif // V8DebuggerClient_h