Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: breakDetails Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
index 7ce109746cb6bd35e0a903610847a9cac26d909d..9510b04dbafbff2fc168dd2f30a7be23bb9e8b87 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
@@ -126,11 +126,6 @@ void WorkerThreadDebugger::unmuteWarningsAndDeprecations(int contextGroupId)
m_workerThread->workerGlobalScope()->consoleMessageStorage()->unmute();
}
-bool WorkerThreadDebugger::callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target)
-{
- return true;
-}
-
v8::Local<v8::Context> WorkerThreadDebugger::ensureDefaultContextInGroup(int contextGroupId)
{
ASSERT(contextGroupId == workerContextGroupId);
@@ -138,6 +133,16 @@ v8::Local<v8::Context> WorkerThreadDebugger::ensureDefaultContextInGroup(int con
return scriptState ? scriptState->context() : v8::Local<v8::Context>();
}
+void WorkerThreadDebugger::beginEnsureAllContextsInGroup(int contextGroupId)
+{
+ DCHECK(contextGroupId == workerContextGroupId);
+}
+
+void WorkerThreadDebugger::endEnsureAllContextsInGroup(int contextGroupId)
+{
+ DCHECK(contextGroupId == workerContextGroupId);
+}
+
void WorkerThreadDebugger::consoleAPIMessage(int contextGroupId, MessageLevel level, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace* stackTrace)
{
DCHECK(contextGroupId == workerContextGroupId);

Powered by Google App Engine
This is Rietveld 408576698