third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp - Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: breakDetails Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

index c9a235ae29e5fd1fdaa3176f9aff9cfab7102c84..78749bce5c23257ba3548241a3d59fb35675d1da 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

@@ -369,7 +369,7 @@ void V8RuntimeAgentImpl::enable(ErrorString* errorString)

{

if (m_enabled)

return;

- m_session->client()->runtimeEnabled();

+ m_debugger->client()->beginEnsureAllContextsInGroup(m_session->contextGroupId());

m_enabled = true;

m_state->setBoolean(V8RuntimeAgentImplState::runtimeEnabled, true);

m_session->debugger()->enableStackCapturingIfNeeded();

@@ -388,7 +388,7 @@ void V8RuntimeAgentImpl::disable(ErrorString* errorString)

m_session->debugger()->disableStackCapturingIfNeeded();

m_session->discardInjectedScripts();

reset();

- m_session->client()->runtimeDisabled();

+ m_debugger->client()->endEnsureAllContextsInGroup(m_session->contextGroupId());

}

void V8RuntimeAgentImpl::reset()