third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h - Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: breakDetails Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

index 888c3d7d51cbf466ba684f1d783c1da66b590e84..cbdab5ef6bbf2eb60f2295228d0684b1cc68f71c 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

@@ -55,9 +55,9 @@ public:

void dispatchProtocolMessage(const String16& message) override;

String16 stateJSON() override;

void addInspectedObject(std::unique_ptr<V8InspectorSession::Inspectable>) override;

- void schedulePauseOnNextStatement(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data) override;

+ void schedulePauseOnNextStatement(const String16& breakReason, const String16& breakDetails) override;

void cancelPauseOnNextStatement() override;

- void breakProgram(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data) override;

+ void breakProgram(const String16& breakReason, const String16& breakDetails) override;

void setSkipAllPauses(bool) override;

void resume() override;

void stepOver() override;