Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorSession.cpp

Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: breakDetails Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorSession.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorSession.cpp b/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
index 92c7fdb56c0475bc6f810d3b906d24e33c10aa6b..5f1d1106720f93bb78843784d42206f1d16ccad1 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
@@ -6,7 +6,6 @@
#include "bindings/core/v8/ScriptController.h"
#include "core/frame/LocalFrame.h"
-#include "core/frame/Settings.h"
#include "core/frame/UseCounter.h"
#include "core/inspector/InspectedFrames.h"
#include "core/inspector/InspectorBaseAgent.h"
@@ -81,7 +80,7 @@ void InspectorSession::dispose()
void InspectorSession::dispatchProtocolMessage(const String& method, const String& message)
{
DCHECK(!m_disposed);
- if (V8InspectorSession::isV8ProtocolMethod(method))
+ if (V8InspectorSession::canDispatchMethod(method))
m_v8Session->dispatchProtocolMessage(message);
else
m_inspectorBackendDispatcher->dispatch(message);
@@ -128,20 +127,6 @@ void InspectorSession::flushProtocolNotifications()
m_notificationQueue.clear();
}
-void InspectorSession::runtimeEnabled()
-{
- if (!m_inspectedFrames)
- return;
- m_inspectedFrames->root()->settings()->setForceMainWorldInitialization(true);
-}
-
-void InspectorSession::runtimeDisabled()
-{
- if (!m_inspectedFrames)
- return;
- m_inspectedFrames->root()->settings()->setForceMainWorldInitialization(false);
-}
-
void InspectorSession::resumeStartup()
{
m_client->resumeStartup();

Powered by Google App Engine
This is Rietveld 408576698