third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp - Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: breakDetails Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp b/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

index 5b52e015a5436383989cf30a72017f8e324ca449..bf418196b7a958c93b0ee8e3d05527a8ea80eb93 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

@@ -72,11 +72,6 @@ v8::Isolate* InspectedContext::isolate() const

void InspectedContext::createInjectedScript()

{

DCHECK(!m_injectedScript);

- v8::HandleScope handles(isolate());

- v8::Local<v8::Context> localContext = context();

- v8::Local<v8::Context> callingContext = isolate()->GetCallingContext();

- if (!callingContext.IsEmpty() && !m_debugger->client()->callingContextCanAccessContext(callingContext, localContext))

- return;

m_injectedScript = InjectedScript::create(this);

}