Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). * Change HeaderCoalescer::headers() to release_headers() passing ownership of SpdyHeaderBlock. * Change BufferedSpdyFramerVisitorInterface::OnHeaders() and OnPushPromise() to take SpdyHeaderBlock by value, allowing for move. * Plumb move through SpdySession::TryCreatePushStream(). * Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). BUG=621905 Committed: https://crrev.com/b8eba6a3e2e46a9d3d4c7be931b04d0a18f71d22 Cr-Commit-Position: refs/heads/master@{#407554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -30 lines) Patch
M net/spdy/buffered_spdy_framer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/header_coalescer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/header_coalescer.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M net/spdy/spdy_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 5 months ago (2016-07-23 00:17:32 UTC) #6
Ryan Hamilton
lgtm
4 years, 5 months ago (2016-07-25 17:58:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174943002/1
4 years, 5 months ago (2016-07-25 19:03:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 20:03:58 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 20:05:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8eba6a3e2e46a9d3d4c7be931b04d0a18f71d22
Cr-Commit-Position: refs/heads/master@{#407554}

Powered by Google App Engine
This is Rietveld 408576698