net/spdy/buffered_spdy_framer.h - Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/buffered_spdy_framer.h

Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/buffered_spdy_framer.h

diff --git a/net/spdy/buffered_spdy_framer.h b/net/spdy/buffered_spdy_framer.h

index 20d71f1bd12346866ee8bde37a4374301646f58e..094e27f0284801552be509e8ac58eec1b6cd3eb6 100644

--- a/net/spdy/buffered_spdy_framer.h

+++ b/net/spdy/buffered_spdy_framer.h

@@ -39,7 +39,7 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramerVisitorInterface {

SpdyStreamId parent_stream_id,

bool exclusive,

bool fin,

- const SpdyHeaderBlock& headers) = 0;

+ SpdyHeaderBlock headers) = 0;

// Called when a data frame header is received.

virtual void OnDataFrameHeader(SpdyStreamId stream_id,

@@ -97,7 +97,7 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramerVisitorInterface {

// Called when a PUSH_PROMISE frame has been parsed.

virtual void OnPushPromise(SpdyStreamId stream_id,

SpdyStreamId promised_stream_id,

- const SpdyHeaderBlock& headers) = 0;

+ SpdyHeaderBlock headers) = 0;

// Called when an ALTSVC frame has been parsed.

virtual void OnAltSvc(

« no previous file with comments | « no previous file | net/spdy/buffered_spdy_framer.cc » ('j') | no next file with comments »