Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: net/spdy/buffered_spdy_framer.cc

Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/buffered_spdy_framer.h ('k') | net/spdy/buffered_spdy_framer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/buffered_spdy_framer.cc
diff --git a/net/spdy/buffered_spdy_framer.cc b/net/spdy/buffered_spdy_framer.cc
index 3eed70855c3b3cc5dfc96a7c792e046acc4ced26..7a06d41e3eae26edcefeddbc01920445f9757f3d 100644
--- a/net/spdy/buffered_spdy_framer.cc
+++ b/net/spdy/buffered_spdy_framer.cc
@@ -114,12 +114,12 @@ bool BufferedSpdyFramer::OnControlFrameHeaderData(SpdyStreamId stream_id,
control_frame_fields_->weight,
control_frame_fields_->parent_stream_id,
control_frame_fields_->exclusive,
- control_frame_fields_->fin, headers);
+ control_frame_fields_->fin, std::move(headers));
break;
case PUSH_PROMISE:
visitor_->OnPushPromise(control_frame_fields_->stream_id,
control_frame_fields_->promised_stream_id,
- headers);
+ std::move(headers));
break;
default:
DCHECK(false) << "Unexpect control frame type: "
@@ -193,17 +193,17 @@ void BufferedSpdyFramer::OnHeaderFrameEnd(SpdyStreamId stream_id,
NOTREACHED();
break;
case HEADERS:
- visitor_->OnHeaders(control_frame_fields_->stream_id,
- control_frame_fields_->has_priority,
- control_frame_fields_->weight,
- control_frame_fields_->parent_stream_id,
- control_frame_fields_->exclusive,
- control_frame_fields_->fin, coalescer_->headers());
+ visitor_->OnHeaders(
+ control_frame_fields_->stream_id, control_frame_fields_->has_priority,
+ control_frame_fields_->weight,
+ control_frame_fields_->parent_stream_id,
+ control_frame_fields_->exclusive, control_frame_fields_->fin,
+ coalescer_->release_headers());
break;
case PUSH_PROMISE:
visitor_->OnPushPromise(control_frame_fields_->stream_id,
control_frame_fields_->promised_stream_id,
- coalescer_->headers());
+ coalescer_->release_headers());
break;
default:
DCHECK(false) << "Unexpect control frame type: "
« no previous file with comments | « net/spdy/buffered_spdy_framer.h ('k') | net/spdy/buffered_spdy_framer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698