net/spdy/header_coalescer.h - Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/header_coalescer.h

Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/header_coalescer.h

diff --git a/net/spdy/header_coalescer.h b/net/spdy/header_coalescer.h

index 8d393ff5ef06df8e730b70d6d5febb57df032588..adbdc66b8ca7e819f29918a3b076296c915d2fee 100644

--- a/net/spdy/header_coalescer.h

+++ b/net/spdy/header_coalescer.h

@@ -21,11 +21,12 @@ class NET_EXPORT_PRIVATE HeaderCoalescer : public SpdyHeadersHandlerInterface {

void OnHeaderBlockEnd(size_t uncompressed_header_bytes) override {}

- const SpdyHeaderBlock& headers() const { return headers_; }

+ SpdyHeaderBlock release_headers();

bool error_seen() const { return error_seen_; }

private:

SpdyHeaderBlock headers_;

+ bool headers_valid_ = true;

size_t header_list_size_ = 0;

bool error_seen_ = false;

bool regular_header_seen_ = false;

« no previous file with comments | « net/spdy/buffered_spdy_framer_unittest.cc ('k') | net/spdy/header_coalescer.cc » ('j') | no next file with comments »