net/spdy/spdy_test_util_common.cc - Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_test_util_common.cc

Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_test_util_common.cc

diff --git a/net/spdy/spdy_test_util_common.cc b/net/spdy/spdy_test_util_common.cc

index e8302a9833cf556f2e070875333d15f1c83cfc3d..71e12b768b148bc897672603d857d27382c52cc4 100644

--- a/net/spdy/spdy_test_util_common.cc

+++ b/net/spdy/spdy_test_util_common.cc

@@ -194,7 +194,7 @@ class PriorityGetter : public BufferedSpdyFramerVisitorInterface {

SpdyStreamId parent_stream_id,

bool exclusive,

bool fin,

- const SpdyHeaderBlock& headers) override {

+ SpdyHeaderBlock headers) override {

if (has_priority) {

priority_ = Http2WeightToSpdy3Priority(weight);

}

@@ -218,7 +218,7 @@ class PriorityGetter : public BufferedSpdyFramerVisitorInterface {

void OnWindowUpdate(SpdyStreamId stream_id, int delta_window_size) override {}

void OnPushPromise(SpdyStreamId stream_id,

SpdyStreamId promised_stream_id,

- const SpdyHeaderBlock& headers) override {}

+ SpdyHeaderBlock headers) override {}

void OnAltSvc(SpdyStreamId stream_id,

base::StringPiece origin,

const SpdyAltSvcWireFormat::AlternativeServiceVector&

« no previous file with comments | « net/spdy/spdy_stream_unittest.cc ('k') | no next file » | no next file with comments »