net/spdy/spdy_stream.h - Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_stream.h

Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_stream.h

diff --git a/net/spdy/spdy_stream.h b/net/spdy/spdy_stream.h

index d96e5e910895eabff0d7a0d86706e002a034a7f0..c9fbfdee05936fda9263addac0219ada1300972d 100644

--- a/net/spdy/spdy_stream.h

+++ b/net/spdy/spdy_stream.h

@@ -308,7 +308,7 @@ class NET_EXPORT_PRIVATE SpdyStream {

// Called by the SpdySession when a frame carrying request headers opening a

// push stream is received. Stream transits to STATE_RESERVED_REMOTE state.

- void OnPushPromiseHeadersReceived(const SpdyHeaderBlock& headers);

+ void OnPushPromiseHeadersReceived(SpdyHeaderBlock headers);

// Called by the SpdySession when response data has been received

// for this stream. This callback may be called multiple times as

« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »