Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: net/spdy/spdy_stream.h

Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SPDY_SPDY_STREAM_H_ 5 #ifndef NET_SPDY_SPDY_STREAM_H_
6 #define NET_SPDY_SPDY_STREAM_H_ 6 #define NET_SPDY_SPDY_STREAM_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 301
302 // Called by the SpdySession (only after 302 // Called by the SpdySession (only after
303 // OnInitialResponseHeadersReceived() has been called) when 303 // OnInitialResponseHeadersReceived() has been called) when
304 // late-bound headers are received for a stream. Returns a status 304 // late-bound headers are received for a stream. Returns a status
305 // code; if it is an error, the stream was closed by this function. 305 // code; if it is an error, the stream was closed by this function.
306 int OnAdditionalResponseHeadersReceived( 306 int OnAdditionalResponseHeadersReceived(
307 const SpdyHeaderBlock& additional_response_headers); 307 const SpdyHeaderBlock& additional_response_headers);
308 308
309 // Called by the SpdySession when a frame carrying request headers opening a 309 // Called by the SpdySession when a frame carrying request headers opening a
310 // push stream is received. Stream transits to STATE_RESERVED_REMOTE state. 310 // push stream is received. Stream transits to STATE_RESERVED_REMOTE state.
311 void OnPushPromiseHeadersReceived(const SpdyHeaderBlock& headers); 311 void OnPushPromiseHeadersReceived(SpdyHeaderBlock headers);
312 312
313 // Called by the SpdySession when response data has been received 313 // Called by the SpdySession when response data has been received
314 // for this stream. This callback may be called multiple times as 314 // for this stream. This callback may be called multiple times as
315 // data arrives from the network, and will never be called prior to 315 // data arrives from the network, and will never be called prior to
316 // OnResponseHeadersReceived. 316 // OnResponseHeadersReceived.
317 // 317 //
318 // |buffer| contains the data received, or NULL if the stream is 318 // |buffer| contains the data received, or NULL if the stream is
319 // being closed. The stream must copy any data from this 319 // being closed. The stream must copy any data from this
320 // buffer before returning from this callback. 320 // buffer before returning from this callback.
321 // 321 //
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 bool write_handler_guard_; 567 bool write_handler_guard_;
568 568
569 base::WeakPtrFactory<SpdyStream> weak_ptr_factory_; 569 base::WeakPtrFactory<SpdyStream> weak_ptr_factory_;
570 570
571 DISALLOW_COPY_AND_ASSIGN(SpdyStream); 571 DISALLOW_COPY_AND_ASSIGN(SpdyStream);
572 }; 572 };
573 573
574 } // namespace net 574 } // namespace net
575 575
576 #endif // NET_SPDY_SPDY_STREAM_H_ 576 #endif // NET_SPDY_SPDY_STREAM_H_
OLDNEW
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698