net/spdy/spdy_stream_unittest.cc - Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_stream_unittest.cc

Issue 2174943002: Avoid SpdyHeaderBlock copy in SpdyStream::OnPushPromiseHeadersReceived(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_stream_unittest.cc

diff --git a/net/spdy/spdy_stream_unittest.cc b/net/spdy/spdy_stream_unittest.cc

index 6257f2c0753fc73d9c99421fd287d606454e70e9..f3199efef798535c8ada355183c32c89727c2bda 100644

--- a/net/spdy/spdy_stream_unittest.cc

+++ b/net/spdy/spdy_stream_unittest.cc

@@ -293,7 +293,7 @@ TEST_F(SpdyStreamTest, PushedStream) {

// Set required request headers.

SpdyHeaderBlock request_headers;

spdy_util_.AddUrlToHeaderBlock(kStreamUrl, &request_headers);

- stream->OnPushPromiseHeadersReceived(request_headers);

+ stream->OnPushPromiseHeadersReceived(std::move(request_headers));

base::Time response_time = base::Time::Now();

base::TimeTicks first_byte_time = base::TimeTicks::Now();

« no previous file with comments | « net/spdy/spdy_stream.cc ('k') | net/spdy/spdy_test_util_common.cc » ('j') | no next file with comments »