Convert media constants to constexpr.

Convert media constants to constexpr.

Replaces silly MEDIA_EXPORT inline functions with constexpr
equivalents. Fingers crossed it passes the bots!

BUG=627984
TEST=compiles

Committed: https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318
Cr-Commit-Position: refs/heads/master@{#406326}

[DaleCurtis, 2016-07-18 23:26:58]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 23:28:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2016-07-19 00:00:48]

dalecurtis@chromium.org changed reviewers:
+ alokp@chromium.org, mmoroz@chromium.org

[DaleCurtis, 2016-07-19 00:00:49]

+alokp, mmoroz@ for review. trybots are green enough.

[commit-bot: I haz the power, 2016-07-19 02:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:04:50]

Dry run: This issue passed the CQ dry run.

[mmoroz, 2016-07-19 08:50:33]

LGTM with a small question about |kNoDecodeTimestamp()|.

https://codereview.chromium.org/2158923004/diff/1/media/formats/mp2t/es_parse...
File media/formats/mp2t/es_parser.cc (right):

https://codereview.chromium.org/2158923004/diff/1/media/formats/mp2t/es_parse...
media/formats/mp2t/es_parser.cc:14: : dts(kNoDecodeTimestamp()),
pts(kNoTimestamp) {}
Shouldn't |kNoDecodeTimestamp()| become |kNoDecodeTimestamp| as well?

https://codereview.chromium.org/2158923004/diff/1/media/formats/mp2t/es_parse...
File media/formats/mp2t/es_parser_h264.cc (right):

https://codereview.chromium.org/2158923004/diff/1/media/formats/mp2t/es_parse...
media/formats/mp2t/es_parser_h264.cc:249: if (current_timing_desc.dts ==
kNoDecodeTimestamp()) {
The same question, don't we replace this as well?

https://codereview.chromium.org/2158923004/diff/1/testing/libfuzzer/fuzzers/e...
File testing/libfuzzer/fuzzers/es_parser_adts_fuzzer.cc (right):

https://codereview.chromium.org/2158923004/diff/1/testing/libfuzzer/fuzzers/e...
testing/libfuzzer/fuzzers/es_parser_adts_fuzzer.cc:19:
media::kNoDecodeTimestamp())) {
Sorry if |kNoDecodeTimestamp()| shouldn't be replaced, but just to clarify. Used
in next two fuzzers as well.

[alokp, 2016-07-19 17:09:13]

lgtm

[DaleCurtis, 2016-07-19 18:20:34]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-07-19 18:20:51]

The CQ bit was unchecked by dalecurtis@chromium.org

[DaleCurtis, 2016-07-19 18:21:42]

I'll send a followup CL for kNoDecodeTimestamp() didn't see that one! Thanks

[DaleCurtis, 2016-07-19 18:21:45]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2016-07-19 18:22:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 18:35:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-19 18:35:50]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 18:37:25]

Description was changed from

==========
Convert media constants to constexpr.

Replaces silly MEDIA_EXPORT inline functions with constexpr
equivalents. Fingers crossed it passes the bots!

BUG=627984
TEST=compiles
==========

to

==========
Convert media constants to constexpr.

Replaces silly MEDIA_EXPORT inline functions with constexpr
equivalents. Fingers crossed it passes the bots!

BUG=627984
TEST=compiles

Committed: https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318
Cr-Commit-Position: refs/heads/master@{#406326}
==========

[commit-bot: I haz the power, 2016-07-19 18:37:27]

Patchset 1 (id:??) landed as
https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318
Cr-Commit-Position: refs/heads/master@{#406326}

[DaleCurtis, 2016-07-19 20:31:24]

Actually converting kDecodeTimestamp is pretty involved, we need to switch
DecodeTimestamp away from using an inner TimeDelta to only having a primitive
type in order to use constexpr. It ends up using too many abstractions in its
current implementation to be switched over.