media/formats/mp4/mp4_stream_parser.cc - Issue 2158923004: Convert media constants to constexpr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp4/mp4_stream_parser.cc

Issue 2158923004: Convert media constants to constexpr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mp4/mp4_stream_parser.cc

diff --git a/media/formats/mp4/mp4_stream_parser.cc b/media/formats/mp4/mp4_stream_parser.cc

index 3dd4ce3fd4ef7d17b3cf64448f5cc9c5ccc73fd3..ffc49a104e8b49354bc89d16f70b631fefed8142 100644

--- a/media/formats/mp4/mp4_stream_parser.cc

+++ b/media/formats/mp4/mp4_stream_parser.cc

@@ -400,7 +400,7 @@ bool MP4StreamParser::ParseMoov(BoxReader* reader) {

RCHECK(config_cb_.Run(std::move(media_tracks), TextTrackConfigMap()));

- StreamParser::InitParameters params(kInfiniteDuration());

+ StreamParser::InitParameters params(kInfiniteDuration);

if (moov_->extends.header.fragment_duration > 0) {

params.duration = TimeDeltaFromRational(

moov_->extends.header.fragment_duration, moov_->header.timescale);