Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: media/base/android/media_statistics.cc

Issue 2158923004: Convert media constants to constexpr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_statistics.cc
diff --git a/media/base/android/media_statistics.cc b/media/base/android/media_statistics.cc
index d3d36bb4ebed42ddd97d940135672f7b2f43b340..e141bbbc5839564c462a555b7cbe7bf4e79956a4 100644
--- a/media/base/android/media_statistics.cc
+++ b/media/base/android/media_statistics.cc
@@ -41,7 +41,7 @@ MediaStatistics::~MediaStatistics() {}
void MediaStatistics::Start(base::TimeDelta current_playback_time) {
DVLOG(1) << __FUNCTION__;
- if (start_time_ == kNoTimestamp()) {
+ if (start_time_ == kNoTimestamp) {
Clear();
start_time_ = current_playback_time;
}
@@ -50,19 +50,19 @@ void MediaStatistics::Start(base::TimeDelta current_playback_time) {
void MediaStatistics::StopAndReport(base::TimeDelta current_playback_time) {
DVLOG(1) << __FUNCTION__;
- if (start_time_ == kNoTimestamp())
+ if (start_time_ == kNoTimestamp)
return; // skip if there was no prior Start().
- if (current_playback_time == kNoTimestamp()) {
+ if (current_playback_time == kNoTimestamp) {
// Cancel the start event and skip if current time is unknown.
- start_time_ = kNoTimestamp();
+ start_time_ = kNoTimestamp;
return;
}
base::TimeDelta duration = current_playback_time - start_time_;
// Reset start time.
- start_time_ = kNoTimestamp();
+ start_time_ = kNoTimestamp;
if (duration < base::TimeDelta::FromSeconds(kMinDurationInSeconds))
return; // duration is too short.
@@ -74,7 +74,7 @@ void MediaStatistics::StopAndReport(base::TimeDelta current_playback_time) {
}
void MediaStatistics::Clear() {
- start_time_ = kNoTimestamp();
+ start_time_ = kNoTimestamp;
audio_frame_stats_.Clear();
video_frame_stats_.Clear();
num_starvations_ = 0;

Powered by Google App Engine
This is Rietveld 408576698