media/formats/webm/webm_stream_parser_unittest.cc - Issue 2158923004: Convert media constants to constexpr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/webm/webm_stream_parser_unittest.cc

Issue 2158923004: Convert media constants to constexpr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/formats/mp2t/es_parser_h264.cc ('K') | « media/formats/webm/webm_stream_parser.cc ('k') | media/formats/webm/webm_tracks_parser.h » ('j') | testing/libfuzzer/fuzzers/es_parser_adts_fuzzer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/formats/webm/webm_stream_parser_unittest.cc

diff --git a/media/formats/webm/webm_stream_parser_unittest.cc b/media/formats/webm/webm_stream_parser_unittest.cc

index 4d0b6103f0cbb6d52ae73cd94b7b2659ea496ace..6a413951d907c3d51b4e68603077c312735a7758 100644

--- a/media/formats/webm/webm_stream_parser_unittest.cc

+++ b/media/formats/webm/webm_stream_parser_unittest.cc

@@ -97,7 +97,7 @@ class WebMStreamParserTest : public testing::Test {

TEST_F(WebMStreamParserTest, VerifyMediaTrackMetadata) {

EXPECT_MEDIA_LOG(testing::HasSubstr("Estimating WebM block duration"))

.Times(testing::AnyNumber());

- StreamParser::InitParameters params(kInfiniteDuration());

+ StreamParser::InitParameters params(kInfiniteDuration);

params.detected_audio_track_count = 1;

params.detected_video_track_count = 1;

params.detected_text_track_count = 0;

@@ -124,7 +124,7 @@ TEST_F(WebMStreamParserTest, VerifyMediaTrackMetadata) {

TEST_F(WebMStreamParserTest, VerifyDetectedTrack_AudioOnly) {

EXPECT_MEDIA_LOG(testing::HasSubstr("Estimating WebM block duration"))

.Times(testing::AnyNumber());

- StreamParser::InitParameters params(kInfiniteDuration());

+ StreamParser::InitParameters params(kInfiniteDuration);

params.detected_audio_track_count = 1;

params.detected_video_track_count = 0;

params.detected_text_track_count = 0;

@@ -134,7 +134,7 @@ TEST_F(WebMStreamParserTest, VerifyDetectedTrack_AudioOnly) {

}

TEST_F(WebMStreamParserTest, VerifyDetectedTrack_VideoOnly) {

- StreamParser::InitParameters params(kInfiniteDuration());

+ StreamParser::InitParameters params(kInfiniteDuration);

params.detected_audio_track_count = 0;

params.detected_video_track_count = 1;

params.detected_text_track_count = 0;

@@ -146,7 +146,7 @@ TEST_F(WebMStreamParserTest, VerifyDetectedTrack_VideoOnly) {

TEST_F(WebMStreamParserTest, VerifyDetectedTracks_AVText) {

EXPECT_MEDIA_LOG(testing::HasSubstr("Estimating WebM block duration"))

.Times(testing::AnyNumber());

- StreamParser::InitParameters params(kInfiniteDuration());

+ StreamParser::InitParameters params(kInfiniteDuration);

params.detected_audio_track_count = 1;

params.detected_video_track_count = 1;

params.detected_text_track_count = 1;