Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chromecast/media/cma/pipeline/media_pipeline_impl.cc

Issue 2158923004: Convert media constants to constexpr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/pipeline/media_pipeline_impl.cc
diff --git a/chromecast/media/cma/pipeline/media_pipeline_impl.cc b/chromecast/media/cma/pipeline/media_pipeline_impl.cc
index 6474b4da0d34328fa8f8f93902f396abffaf18ba..54eeb556a9bbf1d9bf25e92643b648c9d84f58c6 100644
--- a/chromecast/media/cma/pipeline/media_pipeline_impl.cc
+++ b/chromecast/media/cma/pipeline/media_pipeline_impl.cc
@@ -87,7 +87,7 @@ MediaPipelineImpl::MediaPipelineImpl()
audio_decoder_(nullptr),
video_decoder_(nullptr),
pending_time_update_task_(false),
- last_media_time_(::media::kNoTimestamp()),
+ last_media_time_(::media::kNoTimestamp),
statistics_rolling_counter_(0),
audio_bytes_for_bitrate_estimation_(0),
video_bytes_for_bitrate_estimation_(0),
@@ -432,7 +432,7 @@ void MediaPipelineImpl::OnBufferingNotification(bool is_buffering) {
void MediaPipelineImpl::CheckForPlaybackStall(base::TimeDelta media_time,
base::TimeTicks current_stc) {
- DCHECK(media_time != ::media::kNoTimestamp());
+ DCHECK(media_time != ::media::kNoTimestamp);
// A playback stall is defined as a scenario where the underlying media
// pipeline has unexpectedly stopped making forward progress. The pipeline is
@@ -520,7 +520,7 @@ void MediaPipelineImpl::UpdateMediaTime() {
base::TimeDelta media_time = base::TimeDelta::FromMicroseconds(
media_pipeline_backend_->GetCurrentPts());
- if (media_time == ::media::kNoTimestamp()) {
+ if (media_time == ::media::kNoTimestamp) {
pending_time_update_task_ = true;
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE, base::Bind(&MediaPipelineImpl::UpdateMediaTime, weak_this_),
@@ -539,7 +539,7 @@ void MediaPipelineImpl::UpdateMediaTime() {
// so don't interpolate ahead.
if (media_time != last_media_time_) {
max_rendering_time = buffering_controller_->GetMaxRenderingTime();
- if (max_rendering_time == ::media::kNoTimestamp())
+ if (max_rendering_time == ::media::kNoTimestamp)
max_rendering_time = media_time;
// Cap interpolation time to avoid interpolating too far ahead.

Powered by Google App Engine
This is Rietveld 408576698