media/base/android/media_player_bridge.cc - Issue 2158923004: Convert media constants to constexpr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_player_bridge.cc

Issue 2158923004: Convert media constants to constexpr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/android/media_player_bridge.cc

diff --git a/media/base/android/media_player_bridge.cc b/media/base/android/media_player_bridge.cc

index 0014d81db686a8f05cf54e8fba982983b485963d..b04a13d4e7a8d6f1542b9e9a855bbbca5bf3066e 100644

--- a/media/base/android/media_player_bridge.cc

+++ b/media/base/android/media_player_bridge.cc

@@ -394,7 +394,7 @@ base::TimeDelta MediaPlayerBridge::GetDuration() {

JNIEnv* env = base::android::AttachCurrentThread();

const int duration_ms =

Java_MediaPlayerBridge_getDuration(env, j_media_player_bridge_.obj());

- return duration_ms < 0 ? media::kInfiniteDuration()

+ return duration_ms < 0 ? media::kInfiniteDuration

: base::TimeDelta::FromMilliseconds(duration_ms);

}