Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: media/filters/frame_processor_unittest.cc

Issue 2158923004: Convert media constants to constexpr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/frame_processor_unittest.cc
diff --git a/media/filters/frame_processor_unittest.cc b/media/filters/frame_processor_unittest.cc
index 5b356d948fc7c89f810930848e3294782bef1f79..d051e8e58aeba450e30f493f90bb333c092c529d 100644
--- a/media/filters/frame_processor_unittest.cc
+++ b/media/filters/frame_processor_unittest.cc
@@ -49,8 +49,8 @@ class FrameProcessorTestCallbackHelper {
// |new_duration|.
void OnPossibleDurationIncrease(base::TimeDelta new_duration) {
PossibleDurationIncrease(new_duration);
- ASSERT_NE(kNoTimestamp(), new_duration);
- ASSERT_NE(kInfiniteDuration(), new_duration);
+ ASSERT_NE(kNoTimestamp, new_duration);
+ ASSERT_NE(kInfiniteDuration, new_duration);
}
private:
@@ -67,7 +67,7 @@ class FrameProcessorTest : public testing::TestWithParam<bool> {
&FrameProcessorTestCallbackHelper::OnPossibleDurationIncrease,
base::Unretained(&callbacks_)),
new MediaLog())),
- append_window_end_(kInfiniteDuration()),
+ append_window_end_(kInfiniteDuration),
frame_duration_(base::TimeDelta::FromMilliseconds(10)),
audio_id_(FrameProcessor::kAudioTrackId),
video_id_(FrameProcessor::kVideoTrackId) {}
@@ -162,7 +162,7 @@ class FrameProcessorTest : public testing::TestWithParam<bool> {
void CheckExpectedRangesByTimestamp(ChunkDemuxerStream* stream,
const std::string& expected) {
// Note, DemuxerStream::TEXT streams return [0,duration (==infinity here))
- Ranges<base::TimeDelta> r = stream->GetBufferedRanges(kInfiniteDuration());
+ Ranges<base::TimeDelta> r = stream->GetBufferedRanges(kInfiniteDuration);
std::stringstream ss;
ss << "{ ";
@@ -233,7 +233,7 @@ class FrameProcessorTest : public testing::TestWithParam<bool> {
ss << ":" << original_time_in_ms;
// Detect full-discard preroll buffer.
- if (last_read_buffer_->discard_padding().first == kInfiniteDuration() &&
+ if (last_read_buffer_->discard_padding().first == kInfiniteDuration &&
last_read_buffer_->discard_padding().second.is_zero()) {
ss << "P";
}

Powered by Google App Engine
This is Rietveld 408576698