Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/formats/mp2t/es_parser_h264.cc

Issue 2158923004: Convert media constants to constexpr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/formats/mp2t/es_parser.cc ('K') | « media/formats/mp2t/es_parser_adts.cc ('k') | media/formats/mp2t/es_parser_h264_unittest.cc » ('j') | testing/libfuzzer/fuzzers/es_parser_adts_fuzzer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp2t/es_parser_h264.cc
diff --git a/media/formats/mp2t/es_parser_h264.cc b/media/formats/mp2t/es_parser_h264.cc
index d4a7a1b51a09c122457522911504c4dd7096b3b8..871a70de7de5e7d226b32d017ce31a5b7afa9ea8 100644
--- a/media/formats/mp2t/es_parser_h264.cc
+++ b/media/formats/mp2t/es_parser_h264.cc
@@ -235,7 +235,7 @@ bool EsParserH264::EmitFrame(int64_t access_unit_pos,
bool is_key_frame,
int pps_id) {
// Get the access unit timing info.
- // Note: |current_timing_desc.pts| might be |kNoTimestamp()| at this point
+ // Note: |current_timing_desc.pts| might be |kNoTimestamp| at this point
// if:
// - the stream is not fully MPEG-2 compliant.
// - or if the stream relies on H264 VUI parameters to compute the timestamps.
@@ -243,8 +243,7 @@ bool EsParserH264::EmitFrame(int64_t access_unit_pos,
// This part is not yet implemented in EsParserH264.
// |es_adapter_| will take care of the missing timestamps.
TimingDesc current_timing_desc = GetTimingDescriptor(access_unit_pos);
- DVLOG_IF(1, current_timing_desc.pts == kNoTimestamp())
- << "Missing timestamp";
+ DVLOG_IF(1, current_timing_desc.pts == kNoTimestamp) << "Missing timestamp";
// If only the PTS is provided, copy the PTS into the DTS.
if (current_timing_desc.dts == kNoDecodeTimestamp()) {
mmoroz 2016/07/19 08:50:33 The same question, don't we replace this as well?
« media/formats/mp2t/es_parser.cc ('K') | « media/formats/mp2t/es_parser_adts.cc ('k') | media/formats/mp2t/es_parser_h264_unittest.cc » ('j') | testing/libfuzzer/fuzzers/es_parser_adts_fuzzer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698