Add resource provider flag to avoid client-side buffers

Add resource provider flag to avoid client-side buffers

On some platforms, a newly-created buffer was liable to be CPU backed.
This would break code that expected a VBO (aka instanced rendering).
This change adds an optional flag to GrResourceProvider that requires
a buffer to be created in GPU memory.

It also moves the CPU backing logic into Gr land in order to properly
cache real VBOs on platforms that prefer client-side buffers.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143333002

Committed: https://skia.googlesource.com/skia/+/485a12003ab48b54965d6f7172f3183358919d8e

[csmartdalton, 2016-07-13 03:39:42]

Description was changed from

==========
Add resource provider flag to avoid client-side buffers

On some platforms, a newly-created buffer was liable to be CPU backed.
This would break code that expected a VBO (aka instanced rendering).
This change adds an optional flag to GrResourceProvider that requires
a buffer to be created in GPU memory.

It also moves the CPU backing logic into Gr land in order to properly
cache real VBOs on platforms that prefer client-side buffers.

BUG=skia:
==========

to

==========
Add resource provider flag to avoid client-side buffers

On some platforms, a newly-created buffer was liable to be CPU backed.
This would break code that expected a VBO (aka instanced rendering).
This change adds an optional flag to GrResourceProvider that requires
a buffer to be created in GPU memory.

It also moves the CPU backing logic into Gr land in order to properly
cache real VBOs on platforms that prefer client-side buffers.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143333002
==========

[csmartdalton, 2016-07-13 04:33:27]

csmartdalton@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com

[csmartdalton, 2016-07-13 04:33:28]

Adding Greg for any Vulkan concerns

[egdaniel, 2016-07-13 12:46:02]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[egdaniel, 2016-07-13 12:46:03]

adding Jim as he is more connected with the buffer world in Vulkan

[bsalomon, 2016-07-13 14:34:17]

https://codereview.chromium.org/2143333002/diff/20001/src/gpu/GrResourceProvi...
File src/gpu/GrResourceProvider.h (right):

https://codereview.chromium.org/2143333002/diff/20001/src/gpu/GrResourceProvi...
src/gpu/GrResourceProvider.h:108: kRequireVBO_Flag = 0x2,
Can we give this a less GL-centric name? Otherwise lgtm if Jim is OK with the
Vulkan side of things.

[jvanverth1, 2016-07-13 14:59:42]

LGTM + nit

https://codereview.chromium.org/2143333002/diff/20001/include/gpu/GrBuffer.h
File include/gpu/GrBuffer.h (right):

https://codereview.chromium.org/2143333002/diff/20001/include/gpu/GrBuffer.h#...
include/gpu/GrBuffer.h:36: bool isCPUBacked() const { return fCPUData; }
SkToBool(fCPUData);

[csmartdalton, 2016-07-13 16:39:03]

https://codereview.chromium.org/2143333002/diff/20001/include/gpu/GrBuffer.h
File include/gpu/GrBuffer.h (right):

https://codereview.chromium.org/2143333002/diff/20001/include/gpu/GrBuffer.h#...
include/gpu/GrBuffer.h:36: bool isCPUBacked() const { return fCPUData; }
On 2016/07/13 14:59:42, jvanverth1 wrote:
> SkToBool(fCPUData);

Done.

https://codereview.chromium.org/2143333002/diff/20001/src/gpu/GrResourceProvi...
File src/gpu/GrResourceProvider.h (right):

https://codereview.chromium.org/2143333002/diff/20001/src/gpu/GrResourceProvi...
src/gpu/GrResourceProvider.h:108: kRequireVBO_Flag = 0x2,
On 2016/07/13 14:34:17, bsalomon wrote:
> Can we give this a less GL-centric name? Otherwise lgtm if Jim is OK with the
> Vulkan side of things.

Done.

[csmartdalton, 2016-07-13 16:39:08]

The CQ bit was checked by csmartdalton@google.com

[csmartdalton, 2016-07-13 16:39:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jvanverth@google.com, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2143333002/#ps40001
(title: "Add resource provider flag to avoid client-side buffers")

[commit-bot: I haz the power, 2016-07-13 16:39:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 17:16:35]

Description was changed from

==========
Add resource provider flag to avoid client-side buffers

On some platforms, a newly-created buffer was liable to be CPU backed.
This would break code that expected a VBO (aka instanced rendering).
This change adds an optional flag to GrResourceProvider that requires
a buffer to be created in GPU memory.

It also moves the CPU backing logic into Gr land in order to properly
cache real VBOs on platforms that prefer client-side buffers.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143333002
==========

to

==========
Add resource provider flag to avoid client-side buffers

On some platforms, a newly-created buffer was liable to be CPU backed.
This would break code that expected a VBO (aka instanced rendering).
This change adds an optional flag to GrResourceProvider that requires
a buffer to be created in GPU memory.

It also moves the CPU backing logic into Gr land in order to properly
cache real VBOs on platforms that prefer client-side buffers.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143333002

Committed:
https://skia.googlesource.com/skia/+/485a12003ab48b54965d6f7172f3183358919d8e
==========

[commit-bot: I haz the power, 2016-07-13 17:16:36]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/485a12003ab48b54965d6f7172f3183358919d8e

[commit-bot: I haz the power, 2016-07-13 17:16:38]

CQ bit was unchecked.