Added default implementations of GetAcceleratorForCommandId.

Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

TBR=derat@chromium.org
BUG=627344
Committed: https://crrev.com/c3a8965543812efb515b5a8ab56e0621b0c393ee
Cr-Commit-Position: refs/heads/master@{#407416}

[Matt Giuca, 2016-07-12 05:55:56]

Description was changed from

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (about half the overrides;
22 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

BUG=627344
==========

to

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (about half the overrides;
28 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

BUG=627344
==========

[Matt Giuca, 2016-07-12 07:16:52]

Description was changed from

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (about half the overrides;
28 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

BUG=627344
==========

to

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (about half the overrides;
31 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

BUG=627344
==========

[Matt Giuca, 2016-07-12 07:33:57]

Description was changed from

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (about half the overrides;
31 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

BUG=627344
==========

to

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (about half the overrides;
34 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

BUG=627344
==========

[Matt Giuca, 2016-07-12 08:11:42]

Description was changed from

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (about half the overrides;
34 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

BUG=627344
==========

to

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

BUG=627344
==========

[Matt Giuca, 2016-07-13 04:29:05]

mgiuca@chromium.org changed reviewers:
+ avi@chromium.org, thakis@chromium.org

[Matt Giuca, 2016-07-13 04:29:06]

Nico: Follow-up to the previous CL (https://codereview.chromium.org/2133013002).
As I was updating all of the overrides to const, I noticed that more than half
of the overrides just return false. I think it's reasonable for this to be the
default behaviour so we can just delete all the overrides.

Unlike the previous CL, there is no compile error to tell me that I've got them
all, so I have to hope that I did (but there is nothing bad that happens if I
miss one). The process I used was to go through the list of overrides that I had
to change in the previous CL, and deleting any that just said "return false".

Please review ui/base/models/simple_menu_model.* and button_menu_item_model.*.

Avi: For review of
components/renderer_context_menu/render_view_context_menu_base.h (I think the
"virtual override" of this method is totally superfluous but just to make sure).

Everything else is mechanical (deleting methods that return false should have no
effect since the default implementation returns false) and I will TBR the
relevant owners.

[Matt Giuca, 2016-07-13 04:30:48]

Description was changed from

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

BUG=627344
==========

to

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

TBR=derat@chromium.org,hajimehoshi@chromium.org
BUG=627344
==========

[Matt Giuca, 2016-07-13 04:31:18]

TBRs:

derat@chromium.org: ash/*
hajimehoshi@chromium.org: components/translate/*

[Matt Giuca, 2016-07-13 04:31:41]

mgiuca@chromium.org changed reviewers:
+ derat@chromium.org, hajimehoshi@chromium.org

[Avi (use Gerrit), 2016-07-13 04:42:28]

lgtm

[hajimehoshi, 2016-07-13 04:46:26]

components/translate lgtm

[Matt Giuca, 2016-07-13 06:01:14]

Description was changed from

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

TBR=derat@chromium.org,hajimehoshi@chromium.org
BUG=627344
==========

to

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

TBR=derat@chromium.org
BUG=627344
==========

[Matt Giuca, 2016-07-21 00:42:10]

mgiuca@chromium.org changed reviewers:
+ sky@chromium.org

[Matt Giuca, 2016-07-21 00:42:11]

+sky it looks like Nico will be away for some time. Please have a look:
ui/base/models/simple_menu_model.* and button_menu_item_model.*.

[sky, 2016-07-21 15:12:36]

Said files LGTM

[Matt Giuca, 2016-07-22 05:37:21]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-07-22 05:37:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 05:40:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 05:40:17]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Matt Giuca, 2016-07-25 05:03:44]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-07-25 05:03:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
hajimehoshi@chromium.org, avi@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2140963002/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-25 05:03:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 06:27:45]

Description was changed from

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

TBR=derat@chromium.org
BUG=627344
==========

to

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

TBR=derat@chromium.org
BUG=627344
==========

[commit-bot: I haz the power, 2016-07-25 06:27:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-25 06:28:56]

Description was changed from

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

TBR=derat@chromium.org
BUG=627344
==========

to

==========
Added default implementations of GetAcceleratorForCommandId.

Adds the default implementation to SimpleMenuModel and
ButtonMenuItemModel classes that just returns false, and deletes all
subclasses' overrides that just return false (over half the overrides;
39 in total).

Returning false just means you have no accelerators; it is a fine
default and there is no need to have every single subclass explicitly
override and return false.

RenderViewContextMenuBase: Remove the spurious override = 0 (which is
now blocking the default implementation from propagating down).

TBR=derat@chromium.org
BUG=627344

Committed: https://crrev.com/c3a8965543812efb515b5a8ab56e0621b0c393ee
Cr-Commit-Position: refs/heads/master@{#407416}
==========

[commit-bot: I haz the power, 2016-07-25 06:28:58]

Patchset 5 (id:??) landed as
https://crrev.com/c3a8965543812efb515b5a8ab56e0621b0c393ee
Cr-Commit-Position: refs/heads/master@{#407416}