chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc - Issue 2140963002: Added default implementations of GetAcceleratorForCommandId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc

Issue 2140963002: Added default implementations of GetAcceleratorForCommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acceleratorprovider-const

Patch Set: Rebase. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h ('k') | chrome/browser/ui/app_list/app_context_menu.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc b/chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc

index 40de50b0ecb30985a9a59c7e6544bcf99f43b918..7b3cfc6048a44b304bccee1fa8539f3daa4ac6b8 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc

@@ -35,13 +35,6 @@ TestRenderViewContextMenu* TestRenderViewContextMenu::Create(

return menu;

}

-bool TestRenderViewContextMenu::GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) const {

- // None of our commands have accelerators, so always return false.

- return false;

bool TestRenderViewContextMenu::IsItemPresent(int command_id) {

return menu_model_.GetIndexOfCommandId(command_id) != -1;

}