Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2138353002: SimpleMenuModel and ButtonMenuItemModel implement AcceleratorProvider. (Closed)

Created:
4 years, 5 months ago by Matt Giuca
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@menumodel-accelerator-default
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SimpleMenuModel and ButtonMenuItemModel implement AcceleratorProvider. (Actually applies to their Delegate classes, not those classes themselves.) These classes were providing the full AcceleratorProvider interface, so may as well officially implement it. This cleans up some awkward subclasses that inherit both AcceleratorProvider and SimpleMenuModel::Delegate and override the same method in both. BUG=627344 Committed: https://crrev.com/164de0bd6781df7e12d2845ba24689ef74a6183e Cr-Commit-Position: refs/heads/master@{#409138}

Patch Set 1 #

Patch Set 2 : Remove unnecessary forward declaration. #

Patch Set 3 : Rebase. #

Patch Set 4 : Fix compile on Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -34 lines) Patch
M chrome/test/base/menu_model_test.h View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/test/base/menu_model_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/base/models/button_menu_item_model.h View 1 2 3 3 chunks +10 lines, -9 lines 0 comments Download
M ui/base/models/simple_menu_model.h View 1 2 3 3 chunks +11 lines, -8 lines 0 comments Download
M ui/base/models/simple_menu_model.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Matt Giuca
Scott: PTAL, thanks. (Final piece of https://crbug.com/627344 refactor.)
4 years, 4 months ago (2016-08-01 05:24:23 UTC) #3
sky
LGTM
4 years, 4 months ago (2016-08-01 15:03:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138353002/40001
4 years, 4 months ago (2016-08-02 01:18:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/230999)
4 years, 4 months ago (2016-08-02 02:07:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138353002/100001
4 years, 4 months ago (2016-08-02 03:36:06 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 4 months ago (2016-08-02 04:35:52 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 04:37:29 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/164de0bd6781df7e12d2845ba24689ef74a6183e
Cr-Commit-Position: refs/heads/master@{#409138}

Powered by Google App Engine
This is Rietveld 408576698