chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm - Issue 2140963002: Added default implementations of GetAcceleratorForCommandId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm

Issue 2140963002: Added default implementations of GetAcceleratorForCommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acceleratorprovider-const

Patch Set: Rebase. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h ('k') | chrome/browser/ui/cocoa/tabs/tab_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm

diff --git a/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm b/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm

index 833b3317ea77e58ba24164907266a89ab0f13792..549d41b6ec2f32c6222b816402010e7e14a8a3e4 100644

--- a/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm

+++ b/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm

@@ -331,12 +331,6 @@ bool RenderViewContextMenuMac::IsCommandIdEnabled(int command_id) const {

}

-bool RenderViewContextMenuMac::GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) const {

- return false;

void RenderViewContextMenuMac::AppendPlatformEditableItems() {

// OS X provides a contextual menu to set writing direction for BiDi

// languages.