chrome/browser/ui/website_settings/permission_menu_model.cc - Issue 2140963002: Added default implementations of GetAcceleratorForCommandId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_menu_model.cc

Issue 2140963002: Added default implementations of GetAcceleratorForCommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acceleratorprovider-const

Patch Set: Rebase. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/permission_menu_model.h ('k') | components/renderer_context_menu/render_view_context_menu_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_menu_model.cc

diff --git a/chrome/browser/ui/website_settings/permission_menu_model.cc b/chrome/browser/ui/website_settings/permission_menu_model.cc

index 9944b12c3b5ff34bdf92cec2555e83992192d1f9..6b9c781d596ff576b2ce078600303163ad81b06a 100644

--- a/chrome/browser/ui/website_settings/permission_menu_model.cc

+++ b/chrome/browser/ui/website_settings/permission_menu_model.cc

@@ -119,13 +119,6 @@ bool PermissionMenuModel::IsCommandIdEnabled(int command_id) const {

return true;

}

-bool PermissionMenuModel::GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) const {

- // Accelerators are not supported.

- return false;

void PermissionMenuModel::ExecuteCommand(int command_id, int event_flags) {

permission_.setting = static_cast<ContentSetting>(command_id);

callback_.Run(permission_);