chrome/browser/ui/panels/panel_extension_browsertest.cc - Issue 2140963002: Added default implementations of GetAcceleratorForCommandId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_extension_browsertest.cc

Issue 2140963002: Added default implementations of GetAcceleratorForCommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acceleratorprovider-const

Patch Set: Rebase. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_media_menu_model.cc ('k') | chrome/browser/ui/toolbar/app_menu_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_extension_browsertest.cc

diff --git a/chrome/browser/ui/panels/panel_extension_browsertest.cc b/chrome/browser/ui/panels/panel_extension_browsertest.cc

index 54cc0564546accbd66f622421849b08de5e51ce1..cad779f6d74a7753997b1564aba45be68133125b 100644

--- a/chrome/browser/ui/panels/panel_extension_browsertest.cc

+++ b/chrome/browser/ui/panels/panel_extension_browsertest.cc

@@ -125,13 +125,6 @@ class PanelContextMenu : public RenderViewContextMenu {

}

void Show() override {}

- protected:

- // RenderViewContextMenu implementation.

- bool GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* accelerator) const override {

- return false;

- }

};

IN_PROC_BROWSER_TEST_F(PanelExtensionBrowserTest, BasicContextMenu) {