ui/base/models/simple_menu_model.h - Issue 2140963002: Added default implementations of GetAcceleratorForCommandId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/models/simple_menu_model.h

Issue 2140963002: Added default implementations of GetAcceleratorForCommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acceleratorprovider-const

Patch Set: Rebase. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/models/simple_menu_model.h

diff --git a/ui/base/models/simple_menu_model.h b/ui/base/models/simple_menu_model.h

index c86f958bf3175352429e2e0609d4c316e5e3cc93..6c8157577f33d8cf5cf90d17b804017dcca1d17f 100644

--- a/ui/base/models/simple_menu_model.h

+++ b/ui/base/models/simple_menu_model.h

@@ -36,10 +36,10 @@ class UI_BASE_EXPORT SimpleMenuModel : public MenuModel {

virtual bool IsCommandIdVisible(int command_id) const;

// Gets the accelerator for the specified command id. Returns true if the

- // command id has a valid accelerator, false otherwise.

- virtual bool GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) const = 0;

+ // command id has a valid accelerator, false otherwise. By default, returns

+ // false for all commands.

+ virtual bool GetAcceleratorForCommandId(int command_id,

+ ui::Accelerator* accelerator) const;

// Some command ids have labels, sublabels, minor text and icons that change

// over time.

« no previous file with comments | « ui/base/models/button_menu_item_model.cc ('k') | ui/base/models/simple_menu_model.cc » ('j') | no next file with comments »