content/shell/browser/shell_web_contents_view_delegate_views.cc - Issue 2140963002: Added default implementations of GetAcceleratorForCommandId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_web_contents_view_delegate_views.cc

Issue 2140963002: Added default implementations of GetAcceleratorForCommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acceleratorprovider-const

Patch Set: Rebase. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/shell_web_contents_view_delegate_views.cc

diff --git a/content/shell/browser/shell_web_contents_view_delegate_views.cc b/content/shell/browser/shell_web_contents_view_delegate_views.cc

index 26a43b5a36af015b9a7844a22a4912e2fabd3d3a..e36d4d18a190a20d2a9218724de9f5cc3659892e 100644

--- a/content/shell/browser/shell_web_contents_view_delegate_views.cc

+++ b/content/shell/browser/shell_web_contents_view_delegate_views.cc

@@ -32,10 +32,6 @@ class ContextMenuModel : public ui::SimpleMenuModel,

// ui::SimpleMenuModel::Delegate:

bool IsCommandIdChecked(int command_id) const override { return false; }

bool IsCommandIdEnabled(int command_id) const override { return true; }

- bool GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* accelerator) const override {

- return false;

- }

void ExecuteCommand(int command_id, int event_flags) override {

switch (command_id) {

case COMMAND_OPEN_DEVTOOLS:

« no previous file with comments | « components/translate/core/browser/options_menu_model.cc ('k') | ui/app_list/app_list_menu.h » ('j') | no next file with comments »