[DevTools] Replace the target type with capabilities

[DevTools] Replace the target type with capabilities

Capabilities allow for more flexible specification of the devtools
features available when working with a specific target.

BUG=624494
Committed: https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453
Cr-Commit-Position: refs/heads/master@{#405344}

[eostroukhov-old, 2016-07-11 21:42:42]

eostroukhov@google.com changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-07-12 00:34:11]

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js:22:
if (!target.hasBrowserDomains() && target.hasJSDomains()) {
Let's add InspectorTest.is{DedicatedWorker,ServiceWorker,ServiceWorkerPage}

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js:42: var
caps = typeof capabilities === "undefined" ? 0x7F : capabilities;
0x7F? Let's list them explicitly.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:269: if
(WebInspector.targetManager.targets().length > 1 &&
WebInspector.targetManager.mainTarget().hasBrowserDomains())
This logic is wrong. We should show the checkbox if more than one target has js
domains.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:311: var caps =
WebInspector.Target.Capabilities.BROWSER_DOMAINS |
WebInspector.Target.Capabilities.JS_DOMAINS |
WebInspector.Target.Capabilities.NETWORK_DOMAINS |
WebInspector.Target.Capabilities.WORKER_DOMAINS;
No abbreviations.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:447: if
(!target.hasJSDomains())
This should be inverted.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js:438:
var caps = WebInspector.Target.Capabilities.NETWORK_DOMAINS |
WebInspector.Target.Capabilities.WORKER_DOMAINS;
No abbreviations.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:34:
WebInspector.Target.Capabilities = {
Capability

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:35: BROWSER_DOMAINS:
1,
Browser, JS, Network, Worker

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:71: capabilitiesMask:
function()
Who uses this? Let's not expose.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:95: _hasCapability:
function(capability)
Annotate please.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:103:
hasBrowserDomains: function()
Now I think maybe we should call this hasBrowserCapability. WDYT?

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:237: * Returns
observers matching the capabilities mask.
We don't usually put comments like this and rely on the good method name.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:335:
targetsWithJSContext: function()
targetsWithJSDomains

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:30:
WebInspector.targetManager.observeTargets(this);
This one should observe network domains.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js:142:
var targets = target ? [target] : WebInspector.targetManager.targets();
browser domains

[eostroukhov-old, 2016-07-12 21:46:16]

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js:22:
if (!target.hasBrowserDomains() && target.hasJSDomains()) {
On 2016/07/12 00:34:10, dgozman wrote:
> Let's add InspectorTest.is{DedicatedWorker,ServiceWorker,ServiceWorkerPage}

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js:42: var
caps = typeof capabilities === "undefined" ? 0x7F : capabilities;
On 2016/07/12 00:34:10, dgozman wrote:
> 0x7F? Let's list them explicitly.

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:269: if
(WebInspector.targetManager.targets().length > 1 &&
WebInspector.targetManager.mainTarget().hasBrowserDomains())
On 2016/07/12 00:34:11, dgozman wrote:
> This logic is wrong. We should show the checkbox if more than one target has
js
> domains.

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:311: var caps =
WebInspector.Target.Capabilities.BROWSER_DOMAINS |
WebInspector.Target.Capabilities.JS_DOMAINS |
WebInspector.Target.Capabilities.NETWORK_DOMAINS |
WebInspector.Target.Capabilities.WORKER_DOMAINS;
On 2016/07/12 00:34:11, dgozman wrote:
> No abbreviations.

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:447: if
(!target.hasJSDomains())
On 2016/07/12 00:34:11, dgozman wrote:
> This should be inverted.

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js:438:
var caps = WebInspector.Target.Capabilities.NETWORK_DOMAINS |
WebInspector.Target.Capabilities.WORKER_DOMAINS;
On 2016/07/12 00:34:11, dgozman wrote:
> No abbreviations.

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:34:
WebInspector.Target.Capabilities = {
On 2016/07/12 00:34:11, dgozman wrote:
> Capability

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:35: BROWSER_DOMAINS:
1,
On 2016/07/12 00:34:11, dgozman wrote:
> Browser, JS, Network, Worker

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:71: capabilitiesMask:
function()
On 2016/07/12 00:34:11, dgozman wrote:
> Who uses this? Let's not expose.

It was used by the TargetManager - now that have changed.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:95: _hasCapability:
function(capability)
On 2016/07/12 00:34:11, dgozman wrote:
> Annotate please.

This function is now gone.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:103:
hasBrowserDomains: function()
On 2016/07/12 00:34:11, dgozman wrote:
> Now I think maybe we should call this hasBrowserCapability. WDYT?

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:237: * Returns
observers matching the capabilities mask.
On 2016/07/12 00:34:11, dgozman wrote:
> We don't usually put comments like this and rely on the good method name.

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:335:
targetsWithJSContext: function()
On 2016/07/12 00:34:11, dgozman wrote:
> targetsWithJSDomains

Deleted. Not needed any more.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:30:
WebInspector.targetManager.observeTargets(this);
On 2016/07/12 00:34:11, dgozman wrote:
> This one should observe network domains.

Done.

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2137773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js:142:
var targets = target ? [target] : WebInspector.targetManager.targets();
On 2016/07/12 00:34:11, dgozman wrote:
> browser domains

Done.

[dgozman, 2016-07-13 00:08:30]

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js:3:
InspectorTest.isDedicatedWorker = function(target)
Let's move these to inspector-test.js. They are generic enough.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js:42: var
caps = typeof capabilities === "undefined" ?
No abbreviations.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js:167:
if (!targets[i].hasJSCapability())
It should have it due to parameter passed to targets().

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:269: var
shouldShowCheck =
WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser).length
> 1;
Capability.Browser -> Capability.JS

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:269: var
shouldShowCheck =
WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser).length
> 1;
haveMultipleContexts

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:270:
this._showAllMessagesCheckbox.element.classList.toggle("hidden",
shouldShowCheck);
!haveMultipleContexts

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:720:
WebInspector.Main._addWebSocketTarget = function(ws)
Looks like this method is never called. Remove it please.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js:90:
this._loadButton.classList.toggle("multi-target",
WebInspector.targetManager.hasTargets(WebInspector.Target.Capability.JS));
.targets(WebInspector.Target.Capability.JS).length > 1

We are interested in multiple (as in more than one) number of them.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:242: return
this._observers.filter((observer) =>
target.hasAllCapabilities(observer[this._observerCapabiliesMaskSymbol] || 0));
No need for "|| 0"

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:302:
hasTargets: function(capabilitiesMask)
Is this one used?

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:316: return
this._targets.filter((target) => target.hasAllCapabilities(capabilitiesMask ||
0));
No need for "|| 0"

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js (right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js:109: var
mainIsServiceWorker = WebInspector.targetManager.mainTarget().hasJSCapability()
&& !WebInspector.targetManager.mainTarget().hasBrowserCapability();
This should be "hasWorkerCapability && !hasBrowserCapability".

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js:238:
for (var t of targets) {
t -> target

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js:143:
for (var t of targets) {
t -> target

[eostroukhov-old, 2016-07-13 00:36:30]

Thank you for the review. Please take another look.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js:3:
InspectorTest.isDedicatedWorker = function(target)
On 2016/07/13 00:08:29, dgozman wrote:
> Let's move these to inspector-test.js. They are generic enough.

Done.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js:42: var
caps = typeof capabilities === "undefined" ?
On 2016/07/13 00:08:29, dgozman wrote:
> No abbreviations.

Done.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js:167:
if (!targets[i].hasJSCapability())
On 2016/07/13 00:08:29, dgozman wrote:
> It should have it due to parameter passed to targets().

Done.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:269: var
shouldShowCheck =
WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser).length
> 1;
On 2016/07/13 00:08:29, dgozman wrote:
> Capability.Browser -> Capability.JS

Done.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:269: var
shouldShowCheck =
WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser).length
> 1;
On 2016/07/13 00:08:29, dgozman wrote:
> haveMultipleContexts

Done.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:270:
this._showAllMessagesCheckbox.element.classList.toggle("hidden",
shouldShowCheck);
On 2016/07/13 00:08:29, dgozman wrote:
> !haveMultipleContexts

Done.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:720:
WebInspector.Main._addWebSocketTarget = function(ws)
On 2016/07/13 00:08:29, dgozman wrote:
> Looks like this method is never called. Remove it please.

Done.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js:90:
this._loadButton.classList.toggle("multi-target",
WebInspector.targetManager.hasTargets(WebInspector.Target.Capability.JS));
On 2016/07/13 00:08:29, dgozman wrote:
> .targets(WebInspector.Target.Capability.JS).length > 1
> 
> We are interested in multiple (as in more than one) number of them.

Oops. Thanks!

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:242: return
this._observers.filter((observer) =>
target.hasAllCapabilities(observer[this._observerCapabiliesMaskSymbol] || 0));
On 2016/07/13 00:08:29, dgozman wrote:
> No need for "|| 0"

It is for the compiler - so the passed value is never undefined.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:302:
hasTargets: function(capabilitiesMask)
On 2016/07/13 00:08:29, dgozman wrote:
> Is this one used?

There was one usage in Main.js - removed it.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:316: return
this._targets.filter((target) => target.hasAllCapabilities(capabilitiesMask ||
0));
On 2016/07/13 00:08:29, dgozman wrote:
> No need for "|| 0"

Compiler would bark...

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js (right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js:109: var
mainIsServiceWorker = WebInspector.targetManager.mainTarget().hasJSCapability()
&& !WebInspector.targetManager.mainTarget().hasBrowserCapability();
On 2016/07/13 00:08:30, dgozman wrote:
> This should be "hasWorkerCapability && !hasBrowserCapability".

Done.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js:238:
for (var t of targets) {
On 2016/07/13 00:08:30, dgozman wrote:
> t -> target

Done.

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js:143:
for (var t of targets) {
On 2016/07/13 00:08:30, dgozman wrote:
> t -> target

Done.

[dgozman, 2016-07-13 00:41:52]

lgtm with a comment. Nice work!

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:269: var
shouldShowCheck =
WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser).length
> 1;
On 2016/07/13 00:36:29, eostroukhov wrote:
> On 2016/07/13 00:08:29, dgozman wrote:
> > Capability.Browser -> Capability.JS
> 
> Done.

Not done :-)

[eostroukhov-old, 2016-07-13 16:39:18]

On 2016/07/13 00:41:52, dgozman wrote:
> lgtm with a comment. Nice work!
> 
>
https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
> (right):
> 
>
https://codereview.chromium.org/2137773002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:269: var
> shouldShowCheck =
>
WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser).length
> > 1;
> On 2016/07/13 00:36:29, eostroukhov wrote:
> > On 2016/07/13 00:08:29, dgozman wrote:
> > > Capability.Browser -> Capability.JS
> > 
> > Done.
> 
> Not done :-)

Thanks! Fixed for realz this time...

[eostroukhov-old, 2016-07-13 16:41:14]

The CQ bit was checked by eostroukhov@google.com

[eostroukhov-old, 2016-07-13 16:41:14]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2137773002/#ps80001
(title: "One final comment fix")

[commit-bot: I haz the power, 2016-07-13 16:42:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 20:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 20:00:13]

Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js:
While running git apply --index -3 -p1;
  error: third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js: does
not exist in index

Patch:       third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
Index: third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
b/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
index
a91e6bebfdd35680c0e663ab67ed627c9ec33c60..65cc06420a4ad21c4b02994887cc7702ed3333d1
100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
@@ -929,7 +929,7 @@ WebInspector.Spectrum.PaletteGenerator = function(callback)
     /** @type {!Map.<string, number>} */
     this._frequencyMap = new Map();
     var stylesheetPromises = [];
-    for (var target of
WebInspector.targetManager.targets(WebInspector.Target.Type.Page)) {
+    for (var target of
WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser)) {
         var cssModel = WebInspector.CSSModel.fromTarget(target);
         for (var stylesheet of cssModel.allStyleSheets())
             stylesheetPromises.push(new
Promise(this._processStylesheet.bind(this, stylesheet)));

[eostroukhov-old, 2016-07-13 21:55:47]

The CQ bit was checked by eostroukhov@google.com

[eostroukhov-old, 2016-07-13 21:55:48]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2137773002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-13 21:56:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 23:12:00]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-13 23:12:09]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 23:14:43]

Description was changed from

==========
[DevTools] Replace the target type with capabilities

Capabilities allow for more flexible specification of the devtools
features available when working with a specific target.

BUG=624494
==========

to

==========
[DevTools] Replace the target type with capabilities

Capabilities allow for more flexible specification of the devtools
features available when working with a specific target.

BUG=624494

Committed: https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453
Cr-Commit-Position: refs/heads/master@{#405344}
==========

[commit-bot: I haz the power, 2016-07-13 23:14:44]

Patchset 6 (id:??) landed as
https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453
Cr-Commit-Position: refs/heads/master@{#405344}